Feature/fdp 2874 alarm info #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sander van der Heijden <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]>
levi-h
approved these changes
Feb 7, 2025
...ication/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/data/entity/SimulatorState.kt
Outdated
Show resolved
Hide resolved
...ication/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/data/entity/SimulatorState.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/org/gxf/crestdevicesimulator/simulator/response/handlers/InfoAlarmCommandHandler.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/org/gxf/crestdevicesimulator/simulator/response/handlers/InfoAlarmCommandHandler.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/org/gxf/crestdevicesimulator/simulator/response/handlers/InfoAlarmCommandHandler.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/org/gxf/crestdevicesimulator/simulator/response/handlers/InfoAlarmCommandHandler.kt
Outdated
Show resolved
Hide resolved
| @BeforeEach | ||
| fun setUp() { | ||
| simulatorState = SimulatorState() | ||
| simulatorState.resetUrc() |
There was a problem hiding this comment.
Isn't it strange to have to reset things on a newly created instance? Maybe a constructor parameter would be more logical, if there are different viable starting states?
There was a problem hiding this comment.
The default initial state of the simulator URC is "INIT", only for the unit tests, this initial state is not desired.
...tlin/org/gxf/crestdevicesimulator/simulator/response/handlers/InfoAlarmCommandHandlerTest.kt
Outdated
Show resolved
Hide resolved
...tlin/org/gxf/crestdevicesimulator/simulator/response/handlers/InfoAlarmCommandHandlerTest.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Sander van der Heijden <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]>
levi-h
approved these changes
Feb 7, 2025
Signed-off-by: Sander van der Heijden <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]>
|
loesimmens
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.