FDP-2929 ~ Adds alarm command handling and ... #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smvdheijden
commented
Jan 23, 2025
smvdheijden
commented
- Refactors command handling
- Updates dependency management to use toml file
- Replaces mockito by mockK
* Refactors command handling * Updates dependency management to use toml file * Replaces mockito by mockK Signed-off-by: Sander van der Heijden <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]>
loesimmens
requested changes
Jan 27, 2025
...n/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/data/entity/AlarmThresholdValues.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/message/MessageHandler.kt
Outdated
Show resolved
Hide resolved
| import org.junit.jupiter.params.ParameterizedTest | ||
| import org.junit.jupiter.params.provider.ValueSource | ||
|
|
||
| class AlarmCommandHandlerTest { |
There was a problem hiding this comment.
testing command failures?
sanderv
reviewed
Jan 27, 2025
...n/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/data/entity/AlarmThresholdValues.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/message/MessageHandler.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/message/MessageHandler.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/gxf/crestdevicesimulator/simulator/response/handlers/AlarmCommandHandler.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/gxf/crestdevicesimulator/simulator/response/handlers/AlarmCommandHandler.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Sander van der Heijden <[email protected]>
loesimmens
requested changes
Jan 30, 2025
| simulatorState.addDownlink(command) | ||
| } catch (ex: Exception) { | ||
| logger.error { ex } |
There was a problem hiding this comment.
I would except the error logging of the exception at the point where the InvalidCommandException is caught -> in or above handleFailure().
There was a problem hiding this comment.
This notation only logs ex.toString(). Use logger.error(ex) { "Your message here" } for full stack trace
| } catch (ex: InvalidCommandException) { | ||
| handleFailure(command, simulatorState) | ||
| } | ||
| if (!canHandleCommand(command)) { |
There was a problem hiding this comment.
This check is already done in the MessageHandler, right before handleCommand() is called.
There was a problem hiding this comment.
Agree with Loes and defensive programming can be used as an argument to double check. This can be done in a more concise way in Kotlin:
require(canHandleCommand(command)) { "Alarm command handler can not handle command: $command" }This throws an IllegalArgumentException
Signed-off-by: Sander van der Heijden <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]>
loesimmens
approved these changes
Feb 5, 2025
| @@ -3,7 +3,7 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| package org.gxf.crestdevicesimulator.simulator.response.handlers | |||
|
|
|||
| import org.assertj.core.api.Assertions.assertThat | |||
| import org.assertj.core.api.Assertions.* | |||
Signed-off-by: Sander van der Heijden <[email protected]>
|
levi-h
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.