FDP-2551 Firmware update added #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sander Verbruggen <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]> Signed-off-by: Sander Verbruggen <[email protected]>
Signed-off-by: Loes Immens <[email protected]> Signed-off-by: Sander Verbruggen <[email protected]>
Signed-off-by: Loes Immens <[email protected]> Signed-off-by: Sander Verbruggen <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]> Signed-off-by: Sander Verbruggen <[email protected]>
Signed-off-by: Sander Verbruggen <[email protected]>
sanderv
force-pushed
the
feature/FDP-2551-firmware
branch
from
4f6b0ca to
de75e04
Compare
Signed-off-by: Sander Verbruggen <[email protected]>
- messages are no longer read from files, but from DeviceMessage - Simulator state is kept across messages (but not persisted over restarts) - Message is updated with this simulator state before sending - Simulator emulates the capacitor; after 5 messages it takes a break Signed-off-by: Sander Verbruggen <[email protected]>
Can't predict the order and exact content, simplified to just check for a known property in the message Signed-off-by: Sander Verbruggen <[email protected]>
sanderv
force-pushed
the
feature/FDP-2551-firmware
branch
from
e3f7d37 to
490ea18
Compare
loesimmens
requested changes
Oct 30, 2024
|
|
||
| import org.gxf.crestdevicesimulator.simulator.message.DeviceMessageDownlink | ||
|
|
||
| class SimulatorState(val deviceId: String, var fotaMessageCounter: Int = 0) { |
| } | ||
| } | ||
| } | ||
|
|
||
| fun createMessage(resource: Resource): JsonNode = mapper.readTree(resource.inputStream) |
There was a problem hiding this comment.
mapper property can be removed
| } | ||
| pskService.isPendingKeyPresent() -> { | ||
| // Use new PSK with the next message, not in a response to the setter-msg TODO |
Signed-off-by: Sander Verbruggen <[email protected]>
loesimmens
approved these changes
Oct 30, 2024
levi-h
reviewed
Oct 30, 2024
...cation/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/message/CrestNamingStrategy.kt
Outdated
Show resolved
Hide resolved
levi-h
reviewed
Oct 30, 2024
...n/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/handlers/CommandHandler.kt
Outdated
Show resolved
Hide resolved
levi-h
reviewed
Oct 30, 2024
| import org.eclipse.californium.core.CoapResponse | ||
| import org.gxf.crestdevicesimulator.simulator.data.entity.SimulatorState | ||
|
|
||
| fun interface CommandHandler { |
There was a problem hiding this comment.
Maybe overkill, maybe interesting: we might look into a state machine library such as KStateMachine
Signed-off-by: Sander Verbruggen <[email protected]>
Signed-off-by: Sander Verbruggen <[email protected]>
levi-h
approved these changes
Oct 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.