FDP-1961: psk change flow #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
jasperkamerling
changed the title
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
JelleHoffman
requested changes
Mar 26, 2024
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Jasper Kamerling <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
LucianoFavoroso
approved these changes
Mar 27, 2024
JelleHoffman
approved these changes
Mar 27, 2024
smvdheijden
previously requested changes
Mar 27, 2024
application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/data/entity/PreSharedKey.kt
Outdated
Show resolved
Hide resolved
...tion/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/data/repository/PskRepository.kt
Outdated
Show resolved
Hide resolved
|
|
||
| fun setPendingKeyAsInvalid() { | ||
| val identity = simulatorProperties.pskIdentity | ||
| val newPsk = |
There was a problem hiding this comment.
Consider renaming newPsk to pendingPsk or just psk
There was a problem hiding this comment.
Add copyright/license header or maybe even better add a .reuse/dep5 file containing the copyright/license info for the flyway migration scripts.
...cation/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/message/MessageHandlerTests.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Loes Immens <[email protected]>
# Conflicts: # application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskExtractor.kt # application/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/response/command/PskCommandHandlerTest.kt
Signed-off-by: Loes Immens <[email protected]>
Signed-off-by: Loes Immens <[email protected]>
LucianoFavoroso
approved these changes
Apr 2, 2024
Signed-off-by: Loes Immens <[email protected]>
|
jasperkamerling
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.