Feature/fdp 1815 #12
Merged
Feature/fdp 1815 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luciano Favoroso <[email protected]>
Signed-off-by: Luciano Favoroso <[email protected]>
Signed-off-by: Luciano Favoroso <[email protected]>
Signed-off-by: Luciano Favoroso <[email protected]>
Signed-off-by: Luciano Favoroso <[email protected]>
sanderv
reviewed
Jan 25, 2024
application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskKeyExtractor.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskKeyExtractor.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/command/PskCommandHandler.kt
Outdated
Show resolved
Hide resolved
sanderv
reviewed
Jan 25, 2024
...src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/command/PskCommandHandler.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Luciano Favoroso <[email protected]>
sanderv
reviewed
Jan 29, 2024
...rg/gxf/crestdevicesimulator/simulator/response/command/exception/PskHashNotValidException.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskKeyExtractor.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Luciano Favoroso <[email protected]>
Signed-off-by: Luciano Favoroso <[email protected]>
Signed-off-by: Luciano Favoroso <[email protected]>
sanderv
previously approved these changes
Jan 29, 2024
smvdheijden
requested changes
Jan 30, 2024
...rg/gxf/crestdevicesimulator/simulator/response/command/exception/PskHashNotValidException.kt
Outdated
Show resolved
Hide resolved
application/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskExtractorTest.kt
Show resolved
Hide resolved
application/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskExtractorTest.kt
Outdated
Show resolved
Hide resolved
application/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskExtractorTest.kt
Outdated
Show resolved
Hide resolved
application/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskExtractorTest.kt
Outdated
Show resolved
Hide resolved
application/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskExtractorTest.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/gxf/crestdevicesimulator/simulator/response/command/PskCommandHandler.kt
Show resolved
Hide resolved
application/src/test/kotlin/org/gxf/crestdevicesimulator/simulator/response/PskExtractorTest.kt
Show resolved
Hide resolved
Signed-off-by: Luciano Favoroso <[email protected]>
Signed-off-by: Luciano Favoroso <[email protected]>
sanderv
previously approved these changes
Jan 30, 2024
Comment on lines
+19
to
+21
| fun extractKeyFromCommand(command: String) = pskKeyHashSplitterRegex.findAll(command).first().groups[1]!!.value | ||
|
|
||
| fun extractHashFromCommand(command: String) = pskKeyHashSplitterRegex.findAll(command).first().groups[2]!!.value |
There was a problem hiding this comment.
I would rather have one regex findAll instead of 2 but for the simulator this could be good enough
jasperkamerling
previously approved these changes
Jan 30, 2024
smvdheijden
requested changes
Jan 30, 2024
| @InjectMocks | ||
| private lateinit var pskCommandHandler: PskCommandHandler | ||
|
|
||
| private val key = "1234567891234567" |
There was a problem hiding this comment.
I would expect to see an old and a new key in this test.
| @BeforeEach | ||
| fun setup() { | ||
| `when`(simulatorProperties.pskIdentity).thenReturn(identity) | ||
| `when`(pskRepository.findById(any())).thenReturn(Optional.of(PreSharedKey(identity, key, secret))) |
There was a problem hiding this comment.
Here return a PSK with an old key
|
|
||
| assertThatExceptionOfType(InvalidPskHashException::class.java).isThrownBy { | ||
| pskCommandHandler.handlePskChange(pskCommand) | ||
| } |
There was a problem hiding this comment.
I would prefer to have separate sections for act and assert.
Consider adding some verification that both repository and store are not changed as well.
| pskCommandHandler.handlePskChange(pskCommand) | ||
| } | ||
| } | ||
| } |
Signed-off-by: Luciano Favoroso <[email protected]>
LucianoFavoroso
dismissed stale reviews from jasperkamerling and sanderv
via
9417ae3
|
smvdheijden
approved these changes
Feb 1, 2024
sanderv
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.