-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMHE-2164: Set watchdog value #1524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
harrymiddelburgetall
requested changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost flawless implementation. Three minor comments and one comment on naming of the ObjectType type.
.../main/java/org/opensmartgridplatform/dto/valueobjects/smartmetering/NotificationTypeDto.java
Outdated
Show resolved
Hide resolved
osgp/shared/osgp-ws-smartmetering/src/main/resources/schemas/adhoc-ws-smartmetering.xsd
Outdated
Show resolved
Hide resolved
...st/resources/features/osgp-adapter-ws-smartmetering/ad-hoc/SetSpecificAttributeValue.feature
Outdated
Show resolved
Hide resolved
...st/resources/features/osgp-adapter-ws-smartmetering/ad-hoc/SetSpecificAttributeValue.feature
Outdated
Show resolved
Hide resolved
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
harrymiddelburgetall
previously approved these changes
Feb 20, 2025
Signed-off-by: stefanermens <[email protected]>
|
harrymiddelburgetall
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the generic SetSpecificAttributeValue function to GXF. With this function a value in the meter can be set. To avoid security issues, only a limited list of values can be set (at the moment only one: the watchdog timer).
The datatype of the value that is to be set, is checked against the information in the object config. Only if it matches, the set request is executed. For now, only integer values are supported.