SMHE-1871 Onbekende meter events die niet gemapped kunnen worden onde… #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r verzamel event Signed-off-by: Natasja <[email protected]>
…nts_onder_verzamel_event
…r verzamel event update cucumber tests with extra event Signed-off-by: Natasja <[email protected]>
…r verzamel event remove TODO Signed-off-by: Natasja <[email protected]>
…r verzamel event Signed-off-by: Natasja <[email protected]>
…r verzamel event Signed-off-by: Natasja <[email protected]>
…nts_onder_verzamel_event
…r verzamel event add UNKNOWN_EVENT_HEADEND Signed-off-by: Natasja <[email protected]>
harrymiddelburgetall
requested changes
Mar 1, 2024
| @@ -42,4 +44,23 @@ public void theBundleResponseShouldContainAFindEventsResponse(final int nrOfEven | |||
| final FindEventsResponse findEventsResponse = (FindEventsResponse) response; | |||
| assertThat(findEventsResponse.getEvents()).hasSize(nrOfEvents); | |||
| } | |||
|
|
|||
| @And( | |||
| @@ -51,7 +51,8 @@ public enum EventType { | |||
| NTP_SYNC_SUCCESS(43), | |||
| AUTHENTICATION_FAIL(44), | |||
| LIGHT_SENSOR_REPORTS_DARK(45), | |||
| LIGHT_SENSOR_REPORTS_LIGHT(46); | |||
| LIGHT_SENSOR_REPORTS_LIGHT(46), | |||
| UNKNOWN_EVENT_HEADEND(47); | |||
There was a problem hiding this comment.
HEADEND reference in core?
There was a problem hiding this comment.
klopt, dit is de naam zoals gegeven in de story. Het lijkt me het beste als hij overal hetzelfde heet.
| @@ -576,7 +574,8 @@ enum EventTypeDtoLookup { | |||
| KEY_SENT_TO_MBUS_DEVICE_ON_CHANNEL_4( | |||
| EventTypeDto.KEY_SENT_TO_MBUS_DEVICE_ON_CHANNEL_4, 0x83A0, null), | |||
| KEY_ACKNOWLEDGED_BY_MBUS_DEVICE_ON_CHANNEL_4( | |||
| EventTypeDto.KEY_ACKNOWLEDGED_BY_MBUS_DEVICE_ON_CHANNEL_4, 0x83A1, null); | |||
| EventTypeDto.KEY_ACKNOWLEDGED_BY_MBUS_DEVICE_ON_CHANNEL_4, 0x83A1, null), | |||
| UNKNOWN_EVENT_HEADEND(EventTypeDto.UNKNOWN_EVENT_HEADEND, 0x84A1, null); | |||
There was a problem hiding this comment.
Where does this int code come from 0x84A1?
There was a problem hiding this comment.
Deze had ik als nog niet bestaande code toegevoegd. Ik heb er nu 999 van gemaakt, zodat duidelijk is dat hij buiten de bestaande ranges valt.
| @@ -303,7 +303,8 @@ public enum EventType { | |||
| MBUS_STATUS_BIT_30_MANUFACTURER_SPECIFIC_CHANNEL_4(0x839E), | |||
| MBUS_STATUS_BIT_31_MANUFACTURER_SPECIFIC_CHANNEL_4(0x839F), | |||
| KEY_SENT_TO_MBUS_DEVICE_ON_CHANNEL_4(0x83A0), | |||
| KEY_ACKNOWLEDGED_BY_MBUS_DEVICE_ON_CHANNEL_4(0x83A1); | |||
| KEY_ACKNOWLEDGED_BY_MBUS_DEVICE_ON_CHANNEL_4(0x83A1), | |||
| UNKNOWN_EVENT_HEADEND(47); | |||
There was a problem hiding this comment.
HEADEND reference in core?
EventCode 47 also is used for CONFIGURATION_CHANGE?
There was a problem hiding this comment.
Deze is ook aangepast naar 999 zoals in de opmerking hierboven.
…r verzamel event use 999 from unknown event, use then in BundledFindEventsSteps Signed-off-by: Natasja <[email protected]>
harrymiddelburgetall
approved these changes
Mar 4, 2024
…nts_onder_verzamel_event
|
jasperkamerling
deleted the
feature/SMHE-1871_Onbekende_meter_events_onder_verzamel_event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log UNKNOWN_EVENT_HEADEND in case of an unknown event.
https://jenkins.fdp.osgp.cloud/view/SMHE-cucumber/job/gxf-smhe-cucumber-build/199/