SMHE-1841: Make get/set WithList more efficient #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
Signed-off-by: stefanermens <[email protected]>
|
...va/org/opensmartgridplatform/adapter/protocol/dlms/domain/commands/utils/DlmsHelperTest.java
Show resolved
Hide resolved
...ces/features/osgp-adapter-ws-smartmetering/management/SetDeviceCommunicationSettings.feature
Show resolved
Hide resolved
harrymiddelburgetall
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the withListSupported property of a device to withListMax. This new property is the maximum amount of items in a request. The getWithList function in the DlmsHelper automatically divides the list of addresses in to sublists of the maximum amount. If only 1 address is provided or if withListMax is 1, then it will use a normal DLMS GetRequest instead of GetWithList.
The database is updated. All devices with withListSupported to false are set to withListMax = 1. All devices with withListSupported to true are set to withListMax = 32, which is the default that was already used.