handle find_port error codes (#812)

if `find_port` fails to find a free port, we give up and cleanup. Updating vnc/vnc_container accordingly.
OSC · Jul 31, 2023 · e003521 · e003521
1 parent cd3faaf
commit e003521
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/lib/ood_core/batch_connect/templates/vnc.rb b/lib/ood_core/batch_connect/templates/vnc.rb
@@ -137,6 +137,7 @@ def after_script
               # Launch websockify websocket server
               echo "Starting websocket server..."
               websocket=$(find_port)
+              [ $? -eq 0 ] || clean_up 1 # give up if port not found
               #{websockify_cmd} -D ${websocket} localhost:${port}
 
               # Set up background process that scans the log file for successful

diff --git a/lib/ood_core/batch_connect/templates/vnc_container.rb b/lib/ood_core/batch_connect/templates/vnc_container.rb
@@ -173,6 +173,7 @@ def after_script
               module load #{container_module}
               echo "Starting websocket server..."
               websocket=$(find_port)
+              [ $? -eq 0 ] || clean_up 1 # give up if port not found
               #{container_command} exec instance://#{@instance_name} #{websockify_cmd} -D ${websocket} localhost:${port}
 
               # Set up background process that scans the log file for successful