Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v4.0-release-notes.rst #1064

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update v4.0-release-notes.rst #1064

merged 2 commits into from
Jan 7, 2025

Conversation

moffatsadeghi
Copy link
Contributor

My final review before sending to Julie.

https://osc.github.io/ood-documentation-test/moffatsadeghi-idkbranch

Besides what is left in my main feedback ticket, here are my additional proposed changes.

My final review before sending to Julie.
The interface for the file editor has been updated. Users will note
that this page now has the navigation bar. The previous navigation
bar entires have been moved to the left.
The file editor interface has been updated to align with the overall OnDemand design. The navigation bar, now consistent with other OnDemand pages, replaces the previous layout. Options such as "Font Size" and Theme" have been relocated to the left sidebar for improved accessibility.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the same right justification as the previous paragraph? There's a similar comment above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to do this, but how. I don't know how it got like that in the first place and what I need to do in the editor to fix it. Never done this before :) Can you offer help on accommodating what you are asking for

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I can take care of! It's no big deal. It's just pressing enter sometimes to get a new line, nothing special.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a "special enter"? Because I would press enter and it would create a whole new section with spacing above the previous line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates made. I'll give it a second to build then merge. Thanks for the fixups!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would press enter and it would create a whole new section with spacing above the previous line.

I think an empty line in-between would create a new section?

consider this text:

image

that appears like this
image

🤷‍♂️ mabye? IDK, all's well that end's well to me.

@johrstrom johrstrom merged commit 9b7bf68 into develop Jan 7, 2025
1 check passed
@johrstrom johrstrom deleted the moffatsadeghi-idkbranch branch January 7, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants