Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emily's Updates v4.0-release-notes.rst #1059

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Conversation

moffatsadeghi
Copy link
Contributor

Tried my best to make more updates to this doc via eiting straight from the .rst. I couldn't figure out how to edit certain sections or more things.

Modify this link to include the branch name, and possibly the page this PR modifies:

https://osc.github.io/ood-documentation-test/BRANCH-NAME/

Add your description here

Tried my best to make more updates to this doc via eiting straight from the .rst.  I couldn't figure out how to edit certain sections or more things.
Comment on lines +190 to +191
User Mapping Now Accepts User Identifiers
.........................................
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's UIDs (User IDs)? UID is common acronym and googleable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UID I bet is known, its just a small detail to spell out what we are talking about. I did the same for another title I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - works for me!

@moffatsadeghi
Copy link
Contributor Author

Thanks for fixing what went wrong. I was having a hard time fixing why it kept failing. Tried once

@johrstrom
Copy link
Contributor

Thanks for fixing what went wrong. I was having a hard time fixing why it kept failing. Tried once

Yea no problem. Mostly it's title underlines, the underlines have to be as long as the title.

i.e.,:

This works
.....................

When this wont
...............

@johrstrom johrstrom merged commit b85353d into develop Jan 3, 2025
1 check passed
@johrstrom johrstrom deleted the moffatsadeghi-idkbranch branch January 3, 2025 15:22
@johrstrom
Copy link
Contributor

Thanks for the help!

@moffatsadeghi
Copy link
Contributor Author

Thank you for your help! Happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants