Added cluster validation to projects.show page to disable script actions #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Dec 15, 2023
apps/dashboard/app/models/script.rb
Outdated
|
|
||
| def clusters? | ||
| cluster_attribute = SmartAttributes::AttributeFactory.build('auto_batch_clusters', {}) | ||
| !cluster_attribute.select_choices(hide_excludable: false).empty? |
There was a problem hiding this comment.
Can we use any? instead of !empty??
|
I'm working on the CI in another pull request. |
abujeda
force-pushed
the
2690_added_script_cluster_validation_to_projects
branch
from
be72e5f to
3fc0155
Compare
johrstrom
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clusters validation to
projects.showpage.If there are no options defined for the
auto_batch_clustersSmart Attribute, the system will show a flash message and disable all the script actions in theprojects.showpage.Fixes #2690