backport #3200 to 3.0 #3213
Closed
backport #3200 to 3.0 #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rofile for users (#3200)
|
@abujeda this is going to be harder than I thought. I'm bogged down with vacation and 3.1. If you want to refactor this and make a PR against 3.0 you can and I'll cut a release for you, but as it stands I don't really have the time to rework this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #3200 to release 3.0. There were some merge conflicts in the
cherry-pickso we'll have to look this over a bit more than other backports. (notably the configuration was modified in the master branch forrclone_extra_configand I'm now seeing other stuff likegoogle_analytics_tag_id).