-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit logging and code style #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cableman
changed the title
Code style fixes in plugins
WIP: Code style fixes in plugins
Apr 24, 2024
cableman
force-pushed
the
feature/os2form-audit
branch
2 times, most recently
from
April 24, 2024 11:41
4ccf6e4
to
1b72571
Compare
cableman
changed the title
WIP: Code style fixes in plugins
WIP: Audit logging and code style
Apr 26, 2024
cableman
force-pushed
the
feature/os2form-audit
branch
17 times, most recently
from
May 8, 2024 09:40
aae9895
to
5d6927c
Compare
cableman
changed the title
WIP: Audit logging and code style
Audit logging and code style
May 8, 2024
cableman
force-pushed
the
feature/os2form-audit
branch
5 times, most recently
from
May 8, 2024 09:54
26a9d98
to
63db687
Compare
rimi-itk
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the variable containing the message sent to the audit logger should be renamed from $msg
to $auditMessage
to make its use more clear.
Co-authored-by: Mikkel Ricky <[email protected]>
cableman
force-pushed
the
feature/os2form-audit
branch
from
August 21, 2024 07:58
66afdf1
to
711de21
Compare
…2web_datalookup into feature/os2form-audit
ITKDev: Minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add audit logging to personal information lookup requests.
NOTE: We have to make sure that we release this in a major release as renaming the interface is a breaking change (it's used in https://github.com/OS2Forms/os2forms/blob/develop/modules/os2forms_digital_post/src/Helper/DigitalPostHelper.php#L93-L95 and other places in the OS2Forms universe).