-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit logging and code style #12
base: 8.x
Are you sure you want to change the base?
Conversation
4ccf6e4
to
1b72571
Compare
aae9895
to
5d6927c
Compare
26a9d98
to
63db687
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some minor clean-ups requested.
src/Plugin/os2web/DataLookup/ServiceplatformenCPRInterfaceExtended.php
Outdated
Show resolved
Hide resolved
src/Plugin/os2web/DataLookup/ServiceplatformenCPRInterfaceExtended.php
Outdated
Show resolved
Hide resolved
147141e
to
585e277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the variable containing the message sent to the audit logger should be renamed from $msg
to $auditMessage
to make its use more clear.
Co-authored-by: Mikkel Ricky <[email protected]>
66afdf1
to
711de21
Compare
…2web_datalookup into feature/os2form-audit
ITKDev: Minor fixes
Add audit logging to personal information lookup requests.
NOTE: We have to make sure that we release this in a major release as renaming the interface is a breaking change (it's used in https://github.com/OS2Forms/os2forms/blob/develop/modules/os2forms_digital_post/src/Helper/DigitalPostHelper.php#L93-L95 and other places in the OS2Forms universe).