Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit logging and code style #12

Open
wants to merge 21 commits into
base: 8.x
Choose a base branch
from

Conversation

cableman
Copy link

@cableman cableman commented Apr 24, 2024

Add audit logging to personal information lookup requests.

  • Awaiting os2web_audit is made available as an package.

NOTE: We have to make sure that we release this in a major release as renaming the interface is a breaking change (it's used in https://github.com/OS2Forms/os2forms/blob/develop/modules/os2forms_digital_post/src/Helper/DigitalPostHelper.php#L93-L95 and other places in the OS2Forms universe).

@cableman cableman changed the title Code style fixes in plugins WIP: Code style fixes in plugins Apr 24, 2024
@cableman cableman marked this pull request as draft April 24, 2024 10:46
@cableman cableman force-pushed the feature/os2form-audit branch 2 times, most recently from 4ccf6e4 to 1b72571 Compare April 24, 2024 11:41
@cableman cableman changed the title WIP: Code style fixes in plugins WIP: Audit logging and code style Apr 26, 2024
@cableman cableman marked this pull request as ready for review April 26, 2024 11:29
@cableman cableman marked this pull request as draft April 26, 2024 11:30
@cableman cableman force-pushed the feature/os2form-audit branch 17 times, most recently from aae9895 to 5d6927c Compare May 8, 2024 09:40
@cableman cableman changed the title WIP: Audit logging and code style Audit logging and code style May 8, 2024
@cableman cableman force-pushed the feature/os2form-audit branch 5 times, most recently from 26a9d98 to 63db687 Compare May 8, 2024 09:54
@cableman cableman requested a review from rimi-itk May 8, 2024 10:48
Copy link
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor clean-ups requested.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
phpcs.xml.dist Outdated Show resolved Hide resolved
src/Form/DataLookupPluginSettingsForm.php Outdated Show resolved Hide resolved
src/LookupResult/CompanyLookupResult.php Outdated Show resolved Hide resolved
src/Routing/DataLookupRoutes.php Outdated Show resolved Hide resolved
Copy link
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the variable containing the message sent to the audit logger should be renamed from $msg to $auditMessage to make its use more clear.

@cableman cableman marked this pull request as ready for review August 21, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants