Added Schultz Fasit handler #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cableman
requested changes
Oct 17, 2024
| '#description' => $this->t('Specifies which api version to use. Should probably be v2'), | ||
| ]; | ||
|
|
||
| $certificate = $this->settings->getCertificate(); |
There was a problem hiding this comment.
We should real use the key module for this type of data.
There was a problem hiding this comment.
Which have support for different vault backends.
|
|
||
| if (self::LOCATOR_TYPE_AZURE_KEY_VAULT === $locatorType) { | ||
| $httpClient = new GuzzleAdapter(new Client()); | ||
| $requestFactory = new RequestFactory(); |
There was a problem hiding this comment.
Would one not inject a Drupal::httpClient using PSR18/17 interfaces and not be locked into guzzle?
| try { | ||
| $response = $this->client->request('POST', $endpoint, $options); | ||
| } | ||
| catch (GuzzleException $e) { |
There was a problem hiding this comment.
This again locks the module into using guzzle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Schultz Fasit handler
Coding standards are taken care of in #136