Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heat transfer fracture #135

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Heat transfer fracture #135

merged 3 commits into from
Jan 27, 2025

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Sep 26, 2024

Blocked by #108

@streeve streeve self-assigned this Sep 26, 2024
@streeve streeve mentioned this pull request Sep 26, 2024
Open
4 tasks
@streeve streeve marked this pull request as draft October 7, 2024 17:42
@streeve streeve force-pushed the heat_transfer_fracture branch 2 times, most recently from 37db292 to c4ff71a Compare November 11, 2024 18:21
@pabloseleson
Copy link
Collaborator

Related comment (sent also by email):

For the "thermal crack with heat transfer" example with the following in the json file:
"thermal_expansion_coeff" : {"value": 7.5E-6, "unit": "oC^{-1}"},
"specific_heat_capacity" : {"value": 880, "unit": "J/(kg.K)"},

When I solve it with the elastic solver, I get "model.cp = 8.80e+02", which is the right coefficient.
When I solve it with the fracture solver, I get: "model.cp = 7.50e-06", which is the other coefficient.

So, there seems to be a mixing of inputs.

@streeve streeve marked this pull request as ready for review November 25, 2024 14:15
streeve
streeve commented Nov 25, 2024
View reviewed changes
examples/thermomechanics/inputs/thermal_crack_temp.json Outdated Show resolved Hide resolved
examples/thermomechanics/thermal_crack_heat_transfer.cpp Outdated Show resolved Hide resolved
src/CabanaPD_HeatTransfer.hpp Outdated Show resolved Hide resolved
@streeve streeve force-pushed the heat_transfer_fracture branch 2 times, most recently from 0599bfd to 360841d Compare January 24, 2025 15:18
@streeve
Copy link
Collaborator Author

streeve commented Jan 24, 2025

@pabloseleson this is ready for testing with the new problem

@streeve streeve force-pushed the heat_transfer_fracture branch 2 times, most recently from 615d313 to a9a8221 Compare January 27, 2025 15:02
@streeve streeve force-pushed the heat_transfer_fracture branch from a9a8221 to d544f88 Compare January 27, 2025 16:30
@streeve streeve force-pushed the heat_transfer_fracture branch from 969b7cf to aa77cf6 Compare January 27, 2025 16:59
@streeve streeve enabled auto-merge January 27, 2025 17:03
@streeve streeve merged commit f1ed070 into ORNL:main Jan 27, 2025
14 checks passed
@streeve streeve deleted the heat_transfer_fracture branch January 27, 2025 17:09
@streeve streeve added the example New example problem label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloseleson pabloseleson pabloseleson approved these changes

Assignees

@streeve streeve

Labels
example New example problem ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streeve @pabloseleson