Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CMake #82

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve CMake #82

wants to merge 4 commits into from

Conversation

Rombur
Copy link
Collaborator

@Rombur Rombur commented Aug 28, 2018

This PR allows to build the mfmg as a shared library even when CUDA is enabled.

@aprokop can you try this PR on your machine

@ghost ghost assigned Rombur Aug 28, 2018
@ghost ghost added the in progress label Aug 28, 2018
@aprokop
Copy link
Collaborator

aprokop commented Aug 28, 2018

Sure, once I get dealii installed :)

@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   87.25%   87.25%           
=======================================
  Files          27       27           
  Lines        1765     1765           
=======================================
  Hits         1540     1540           
  Misses        225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9490d6b...9f26906. Read the comment docs.

@Rombur Rombur force-pushed the cmake branch 3 times, most recently from 446ab7f to bf936d6 Compare August 29, 2018 20:22
@Rombur
Copy link
Collaborator Author

Rombur commented Aug 30, 2018

@aprokop I know this does not pass the tests but can you still try it. I would be interested to see if the problem is reproducible outside docker.

@Rombur
Copy link
Collaborator Author

Rombur commented Oct 19, 2018

I am giving up on this for now. While removing the stubs fixes the problem in docker it seems that stubs are not the real reason of the problem.

@masterleinad masterleinad mentioned this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants