Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow finding TPLs by environment variables #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

masterleinad
Copy link
Collaborator

Also provide an error message in case AmgX was not found.

@ghost ghost assigned masterleinad Apr 3, 2019
@ghost ghost added the in progress label Apr 3, 2019
@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          53       53           
  Lines        2199     2199           
=======================================
  Hits         1930     1930           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c96e14...0368f20. Read the comment docs.

cmake/SetupTPLs.cmake Show resolved Hide resolved
Copy link
Collaborator

@Rombur Rombur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge this. The build system and this part in particular is very brittle and it is too important to start making change to it at this time in the project. Passing the jenkins is not enough, we need to try on different machines.

@dalg24
Copy link
Collaborator

dalg24 commented Apr 4, 2019

Let's not merge this. The build system and this part in particular is very brittle and it is too important to start making change to it at this time in the project. Passing the jenkins is not enough, we need to try on different machines.

This patch is armless and gives cleaner code in CMake.

@dalg24
Copy link
Collaborator

dalg24 commented Apr 4, 2019

We can strip the part with the env variables if you don't like but this is the correct way to detect the AmgX lib and link against it.

@Rombur
Copy link
Collaborator

Rombur commented Apr 4, 2019

We shouldn't merge anything in the build system until we know it works on Docker, my machine, and Andrey's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants