-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow finding TPLs by environment variables #149
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 53 53
Lines 2199 2199
=======================================
Hits 1930 1930
Misses 269 269 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not merge this. The build system and this part in particular is very brittle and it is too important to start making change to it at this time in the project. Passing the jenkins is not enough, we need to try on different machines.
This patch is armless and gives cleaner code in CMake. |
We can strip the part with the env variables if you don't like but this is the correct way to detect the AmgX lib and link against it. |
We shouldn't merge anything in the build system until we know it works on Docker, my machine, and Andrey's. |
Also provide an error message in case
AmgX
was not found.