Lanczos tests #136
Lanczos tests #136
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 87.04% 87.79% +0.75%
==========================================
Files 53 53
Lines 2153 2171 +18
==========================================
+ Hits 1874 1906 +32
+ Misses 279 265 -14
Continue to review full report at Codecov.
|
|
The tests finally pass. |
| @@ -334,6 +340,6 @@ BOOST_AUTO_TEST_CASE(weight_sum, *utf::tolerance(1e-4)) | |||
| e[i] = 1.; | |||
| e.compress(::dealii::VectorOperation::insert); | |||
| restrictor_matrix.vmult(ee, e); | |||
| BOOST_TEST(ee.l1_norm() == 1.); | |||
| BOOST_TEST(ee.l1_norm() == 1., tt::tolerance(2e-4)); | |||
There was a problem hiding this comment.
So you relaxed the tolerance (x2)? I missed that change. Is that how you got the tests to pass?
There was a problem hiding this comment.
c.c. @Rombur who knows the restriction matrix tests better than I do. Is that OK?
There was a problem hiding this comment.
I relaxed the tolerance for restriction test, yes. The tolerances that I was getting from the test when running with Lanczos were around 1.1e-4.
There was a problem hiding this comment.
Marking it as "resolved". I just want to make sure that Bruno sees that. You don't need to wait for his feedback to merge.
An alternative version of #132. We don't introduce a new stopping criteria, and instead just loosen tolerance for the hierarchy tests.
Fix #115.