#43 Coding style

OPUS4 · May 8, 2023 · bad0916 · bad0916
1 parent 0406327
commit bad0916
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/src/Rules/Conditions/AccountCondition.php b/src/Rules/Conditions/AccountCondition.php
@@ -32,7 +32,11 @@
 namespace Opus\Import\Rules\Conditions;
 
 use Opus\Import\ImportRuleConditionInterface;
-use Zend_Auth; // TODO SECURITY depend on OPUS classes instead
+use Zend_Auth;
+
+use function strcasecmp;
+
+// TODO SECURITY depend on OPUS classes instead
 
 class AccountCondition implements ImportRuleConditionInterface
 {

diff --git a/test/Rules/Conditions/AccountConditionTest.php b/test/Rules/Conditions/AccountConditionTest.php
@@ -35,10 +35,12 @@
 use OpusTest\Import\TestAsset\MockAuthAdapter;
 use OpusTest\Import\TestAsset\TestCase;
 use Zend_Auth;
+use Zend_Auth_Storage_Interface;
 use Zend_Auth_Storage_NonPersistent;
 
 class AccountConditionTest extends TestCase
 {
+    /** @var Zend_Auth_Storage_Interface */
     private $authStorage;
 
     public function setUp(): void
@@ -60,7 +62,7 @@ public function tearDown(): void
     public function testConstruct()
     {
         $condition = new AccountCondition([
-            'account' => 'sword1'
+            'account' => 'sword1',
         ]);
 
         $this->assertEquals('sword1', $condition->getExpectedUser());
@@ -71,7 +73,7 @@ public function testAppliesTrue()
         Zend_Auth::getInstance()->authenticate(new MockAuthAdapter('sword1'));
 
         $condition = new AccountCondition([
-            'account' => 'sword1'
+            'account' => 'sword1',
         ]);
 
         $this->assertTrue($condition->applies());
@@ -82,7 +84,7 @@ public function testAppliesFalse()
         Zend_Auth::getInstance()->authenticate(new MockAuthAdapter('sword2'));
 
         $condition = new AccountCondition([
-            'account' => 'sword1'
+            'account' => 'sword1',
         ]);
 
         $this->assertFalse($condition->applies());

diff --git a/test/TestAsset/MockAuthAdapter.php b/test/TestAsset/MockAuthAdapter.php
@@ -52,7 +52,7 @@ public function __construct($user)
      */
     public function authenticate()
     {
-        $identity = ['username'=> $this->user];
+        $identity = ['username' => $this->user];
         return new Zend_Auth_Result(Zend_Auth_Result::SUCCESS, $identity);
     }
 }