Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build support for CentOS and Docker #23

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

rdimitrov
Copy link

Description

For the time being, the OAI project can be built only on RHEL using Podman.

The following PR aims to add support for CentOS as a base OS image and Docker as a container engine.

This is the status so far -

  1. Everything but MME is building successfully.
  2. Although the images are building okay, it's still not clear if they also work as expected.

In that sense, it'd be really helpful if someone can assist with that! 👍

Motivation and Context

How Has This Been Tested?

  • Covered by existing integration testing
  • Added integration testing to cover
  • Tested locally
  • Have not tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

rdimitrov and others added 10 commits December 17, 2019 17:15
Signed-off-by: Radoslav Dimitrov <[email protected]>
… basic

Docker image.

Signed-off-by: Nikolay Nikolaev <[email protected]>
Enabling Ubuntu and others
Signed-off-by: Radoslav Dimitrov <[email protected]>
* Check for the presence of /etc/os-release

This enables the build on non-systemd/non-linux *nixes, like OSX.

Signed-off-by: Nikolay Nikolaev <[email protected]>

* Detect podman presence, otherwise use docker

Signed-off-by: Nikolay Nikolaev <[email protected]>

* Adapt sed usage for non-GNU versions

Signed-off-by: Nikolay Nikolaev <[email protected]>

* Cleanup all Centos8 Dockerfiles

Remove unrelated labels and properties.

Signed-off-by: Nikolay Nikolaev <[email protected]>
The COPY command had a syntax error in some of the dockerfiles

Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
@kaltenbe
Copy link
Contributor

Dear authors,
thanks for this pull request. I am happy to see that VMware took an interest in this. It might be worth also starting a discussion between Eurecom, RedHat and VMware on how to possibly collaborate on this in the future. Let us know if you are availiable for such a call.
We shall definitely merge in this pull request, but we need to figure out a few details before. I have seen that you have added a VMware copyright plus the apache header in the new files whereas we haven't done this for any of the other files. So let us check internally if we should do this before.
Florian.

@rdimitrov
Copy link
Author

@kaltenbe: Thank you for your feedback! I'd be glad to assist, so we can move this forward 👍

Also, I'd be happy if there's someone willing to help with resolving the failure to build the MME image and possibly help to verify that the images are built okay and run as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants