Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough params #708

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Passthrough params #708

merged 15 commits into from
Jan 24, 2024

Conversation

pbrubeck
Copy link
Collaborator

No description provided.

@pbrubeck pbrubeck changed the title Connorjward/passthrough params Passthrough params Sep 21, 2023
Copy link
Collaborator

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this but I wrote all the code! We can review this on Wednesday.

Copy link
Collaborator

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon this is fine. It is a hack and not super well documented, but it should be straightforward (and cleaner) to make pyop3 handle this in the near future.

@dham dham merged commit e0a4d3a into master Jan 24, 2024
4 checks passed
@dham dham deleted the connorjward/passthrough-params branch January 24, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants