Disable TLS/C++ tests with some unsupported compilers #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
changed the title
|
|
etienne-lms
reviewed
Aug 19, 2020
host/xtest/regression_1000.c
Outdated
| res = TEEC_InvokeCommand(&session, TA_OS_TEST_CMD_TLS_TEST_MAIN, NULL, | ||
| &ret_orig); | ||
| if (res == TEEC_ERROR_NOT_SUPPORTED) | ||
| printf("TA returned TEEC_ERROR_NOT_SUPPORTED\n"); |
There was a problem hiding this comment.
Do_ADBG_Log() instead of printf().
For consistency with other skipped tested:
Do_ADBG_Log(" - 1029 - skip test, Thread Local Storage test not supported");
There was a problem hiding this comment.
OK, I will use Do_ADBG_Log() and adjust the format for more consistency. But I'd rather not repeat "Thread Local Storage" which is printed immediately before. It's better to inform the user that the cause is with the TA I think.
|
Update |
|
|
The Thread Local Storage test (__thread attribute) is modified to accept TEE_ERROR_NOT_SUPPORTED without failing. This return value will be used in a later commit in case an unsupported compiler is used to build the TA. Signed-off-by: Jerome Forissier <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Etienne Carriere <[email protected]>
In 64-bit mode, the Thead Local Storage tests currently pass only with Clang, or GCC 8 or later. Earlier GCC versions (6.2, 7.3) generate an unsupported relocation type: * regression_1006 Test Basic OS features E/LD: e64_relocate:538 Unknown relocation type 1031 E/TC:?? 0 init_with_ldelf:232 ldelf failed with res: 0xffff0005 [...] regression_1006 FAILED TLS is not currently useful in itself, since OP-TEE doesn't have multi- threaded TAs. It was implemented primarily to support C++ because the GNU C++ runtime depends on it. To avoid failures in the regression tests of people who upgrade their OP-TEE environment and who possibly use older toolchains, the TLS tests should be ignored unless a "known good" compiler is used. Similarly, since the C++ tests depend on TLS, they need to be disabled too with Aarch64 GCC < 8 (note they are already disabled with Clang). Signed-off-by: Jerome Forissier <[email protected]> Tested-by: Jerome Forissier <[email protected]> (QEMU/QEMUv8, GCC 8.3/GCC 6.2/Clang 10) Acked-by: Jens Wiklander <[email protected]> Acked-by: Etienne Carriere <[email protected]>
jforissier
force-pushed
the
tls-and-c++-check-compiler
branch
from
7a9e17a to
158be32
Compare
|
@jforissier I'm getting below build errors with aosp clang 11.0.2 if variables in |
|
Hi @vchong, This |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses OP-TEE/optee_os#4008 (comment).