Allow to seed software RNG without STM32 RNG peripheral #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tbourgoi
force-pushed
the
rng_default
branch
from
4674403
to
1544153
Compare
|
both tag applied on the 2 commits |
etienne-lms
approved these changes
Sep 23, 2024
Rename the function plat_rng_init() to __plat_rng_init() and define plat_rng_init() as a weak alias of __plat_rng_init(). This allow to use the default RNG initialization in the platform plat_rng_init() function. Signed-off-by: Thomas Bourgoin <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Jerome Forissier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
In case RNG peripheral is not enabled in device tree, fallback to the default RNG initialization implementation. Signed-off-by: Thomas Bourgoin <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Jerome Forissier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
tbourgoi
force-pushed
the
rng_default
branch
from
1544153
to
622900b
Compare
|
tag applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the node RNG is disabled in the device tree and we have compiled the driver stm32_rng.c, the function plat_rng_init() will try to read a random value from the RNG peripheral to seed the PRNG of OP-TEE but the peripheral is not initialized.
As a fallback, we could use the default implementation of plat_rng_init() to seed PRNG.
This pull request aims to rename the default implementation of plat_rng_init() to __plat_rng_init().
The second patch update the stm32_rng driver to fallback to __plat_rng_init() if the RNG peripheral is disabled in the DT.