ta: pkcs11: fix memory leak

On update_persistent_object_attributes failure, head_new (stored in obj->attributes) is not freed, causing a memory leak. Reported-by: Christian Zoia <[email protected]> Closes: #7023 Fixes: 6959626 ("ta: pkcs11: preserve object when set attribute fails") Signed-off-by: Georges Savoundararadj <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
OP-TEE · Sep 6, 2024 · 56be8c8 · 56be8c8
1 parent 8cd20f2
commit 56be8c8
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/ta/pkcs11/src/object.c b/ta/pkcs11/src/object.c
@@ -1094,6 +1094,7 @@ enum pkcs11_rc entry_set_attribute_value(struct pkcs11_client *client,
 	if (get_bool(obj->attributes, PKCS11_CKA_TOKEN)) {
 		rc = update_persistent_object_attributes(obj);
 		if (rc) {
+			TEE_Free(obj->attributes);
 			obj->attributes = head_old;
 			goto out;
 		}