-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request response parameters #19
Conversation
…igital/eq-cir-converter-service into request-response-parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some comments for discussion at this early stage 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be an issue with the linting step at the moment, when I run locally it seems to catch some errors that are not being reported as part of the run in the actions workflow
@berroar Linting is alright in local and github, all issues are solved, could you please check. |
…igital/eq-cir-converter-service into request-response-parameters
What is the context of this PR?
https://jira.ons.gov.uk/browse/CIMS-37
This PR is to define the request and response parameters for the API endpoint
Request body -
Request query parameters -
Response -
How to review
Run the commands
make docker-build
andmake docker-run
to spin up the local application, launch the FastAPI webpage and test the endpoint with the below sample JSON in the POST request.{"valid_json": "valid_json"}