Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request response parameters #19

Merged
merged 40 commits into from
Feb 7, 2025
Merged

Conversation

sudeepkunhis
Copy link
Collaborator

@sudeepkunhis sudeepkunhis commented Jan 13, 2025

What is the context of this PR?

https://jira.ons.gov.uk/browse/CIMS-37

This PR is to define the request and response parameters for the API endpoint

Request body -

  • CIR schema JSON

Request query parameters -

  • current version - string - this will be later restricted to v9.0.0 (aligned to the current Live validator version)
  • target version - string - this will be later restricted to v10.0.0

Response -

  • Converted CIR schema JSON (for now, this will be same as the input schema without any transformation)
  • status - 200 (successful)

How to review

Run the commands make docker-build and make docker-run to spin up the local application, launch the FastAPI webpage and test the endpoint with the below sample JSON in the POST request.

{"valid_json": "valid_json"}

Copy link
Collaborator

@liamtoozer liamtoozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some comments for discussion at this early stage 👍

src/routers/schema_router.py Outdated Show resolved Hide resolved
src/routers/schema_router.py Outdated Show resolved Hide resolved
src/routers/schema_router.py Outdated Show resolved Hide resolved
src/routers/schema_router.py Outdated Show resolved Hide resolved
tests/unit/test_post_schema.py Outdated Show resolved Hide resolved
tests/unit/conftest.py Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
liamtoozer
liamtoozer previously approved these changes Jan 22, 2025
Makefile Outdated Show resolved Hide resolved
src/routers/schema_router.py Outdated Show resolved Hide resolved
martyncolmer
martyncolmer previously approved these changes Jan 24, 2025
Dockerfile Outdated Show resolved Hide resolved
src/app/routers/schema_router.py Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/tests/unit/routers/test_schema_router.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Collaborator

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be an issue with the linting step at the moment, when I run locally it seems to catch some errors that are not being reported as part of the run in the actions workflow

@sudeepkunhis
Copy link
Collaborator Author

@berroar Linting is alright in local and github, all issues are solved, could you please check.

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
eq_cir_converter_service/app/config/logging_config.py Outdated Show resolved Hide resolved
eq_cir_converter_service/app/routers/schema_router.py Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
eq_cir_converter_service/app/config/logging_config.py Outdated Show resolved Hide resolved
tests/unit/routers/test_schema_router.py Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@sudeepkunhis sudeepkunhis merged commit ba294ab into main Feb 7, 2025
6 checks passed
@sudeepkunhis sudeepkunhis deleted the request-response-parameters branch February 7, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants