Fix flakey macro tests #3414
Open
Fix flakey macro tests #3414
+17
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
added
Tech improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3401
Added awaits to some of the expects that are causing some flakiness on the autosuggest and upped a wait on the modal tests. I have now run the tests 10 times in a row and they passed every time which you can see in the test attempts in the GitHub action below. I think if we continue to see flakiness after this PR has been merged we should revisit this again.
How to review this PR
Check the macro test logs for the last commit where I made changes rather than the merging in main commits (https://github.com/ONSdigital/design-system/actions/runs/11631038531/job/32395239872?pr=3414) to see that the tests have been run 10 times and passed every time.
Checklist
This needs to be completed by the person raising the PR.