Fix some type problems detected by clang 4 on OpenBSD/adJ 6.2

[vtamara]

In the process of helping with ONLYOFFICE/build_tools#808

[vtamara]

I notice you integrated changes of ASCOfficeOdfFileW/source/OdfFormat/odf_page_layout_state.cpp
and
ASCOfficeOdfFileW/source/OdfFormat/odf_drawing_context.cpp

[agolybev]

Hi @vtamara.
Yes, @ElenaSubbotina found it useful. Now I'm trying to reason her to merge your pullrequest.

[vtamara]

Problems that I can have with the coding style, feel free to correct or tell me and I will correct.

[vtamara]

@agolybev I have been able to compile ONLYOFFICE-core completely in OpenBSD/adJ 6.2. However I have problems linking, specialy with v8.

I understand that the current version of core requires version 6.0 ¿right?

The libv8 port in OpenBSD is too old (3.12.19), and the v8 included in some ports of node are not 6.0 (OpenBSD 6.2 uses node 6.11.2 which includes v8 version 5.1.281, while OpenBSD 6.3 uses node 8.9.4 wich includes v8 version 6.1.534).

I could try to compile version 6.0, but it doesn't seem trivial.

Is it possible to link onlyoffice-core with v8 version 6.1.534 ?

[agolybev]

Hi @vtamara,
Yes, the core module requires V8 v6.0. The version number is related with minimal version of gcc. We use the hightest version of V8 which can be compiled with gcc-4.8. It is the hightest version of gcc for Ubuntu 14.04.
Yes, you can try using another version of V8 but we can't garantee its working.

Also I have few comments for you pull request:
First, could you remove cosmetic changes:
https://github.com/ONLYOFFICE/core/pull/65/files#diff-3254ca8ef145fd640eb0d0119665c4f1
https://github.com/ONLYOFFICE/core/pull/65/files#diff-5306559b33a83b6d10722b81713bf5cc
Second, could check m_bData with false or use logical negation operator !
https://github.com/ONLYOFFICE/core/pull/65/files#diff-dc276deb33d9445467b7004c1c179105

[vtamara]

I'm glad that some changes were useful.