Move discord webhook logic to seperate file

[goratt12]

PR Checklist

• - Commit messages are descriptive, it will be used in our Release Notes

PR Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Developer experience (improves developer workflows for contributing to the project)

Description

** tested and working **
Refactored the notification logic by keeping only the Discord notification handling in firebase-discord.ts file. The notifyPinAccepted and notifyHowToAccepted functions have been separated into their respective files, mapPinUpdates/index.ts and howtoUpdates/index.ts.

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

---

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

[goratt12]

Encountered Github automatic secret push block, resolved it by these steps:
https://docs.github.com/en/code-security/secret-scanning/working-with-push-protection#bypassing-push-protection-when-working-with-the-command-line
When merging my PR the maintainer will probably have to do the same to allow the secret to enter the code base

[mariojsnunes]

there are some conflicts. (probably due to the vite migration, sorry!)

[cypress]

1 flaky test on run #5863 ↗︎

0

75

1

0

1

Details:

fix(functions): fixed import errors
Project: onearmy-community-platform	Commit: 970ead4b87
Status: Passed	Duration: 12:56 💡
Started: Jun 25, 2024 12:10 PM	Ended: Jun 25, 2024 12:22 PM

  src/integration/howto/read.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
... > [See all info]		Test Replay Screenshots Video

Review all test suite changes for PR #3636 ↗︎

[benfurber]

Seen the error @goratt12? Looks relevant.

[goratt12]

Seen the error @goratt12? Looks relevant.

Yeah I don't know how I missed it, fixed it now.
The unit tests that are failing now are not related, Possibly flaky

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.71%. Comparing base (1fa25fc) to head (970ead4).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3636      +/-   ##
==========================================
+ Coverage   73.68%   74.71%   +1.03%     
==========================================
  Files          41       44       +3     
  Lines        1254     1317      +63     
  Branches      253      268      +15     
==========================================
+ Hits          924      984      +60     
- Misses        308      311       +3     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.