Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userguide: explain rule types and categorization - v6 #12113

Closed

Conversation

jufajardini
Copy link
Contributor

Add documentation about the rule types introduced by 2696fda.

Add doc tags around code definitions that are referenced in the docs.

Task #https://redmine.openinfosecfoundation.org/issues/7031

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7031

Built docs: https://suri-rtd-test.readthedocs.io/en/doc-sigtypes-et-properties-v6/rules/intro.html#rule-types-and-categorization

Previous PR: #12112

Describe changes:

  • incorporate last feedback (fix dcerpc keyword, move flow, if stateful note upwards a bit)

Add documentation about the rule types introduced by 2696fda.

Add doc tags around code definitions that are referenced in the docs.

Task #https://redmine.openinfosecfoundation.org/issues/7031
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (278dc24) to head (647d8a7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12113      +/-   ##
==========================================
+ Coverage   83.23%   83.28%   +0.04%     
==========================================
  Files         906      906              
  Lines      257647   257647              
==========================================
+ Hits       214458   214575     +117     
+ Misses      43189    43072     -117     
Flag Coverage Δ
fuzzcorpus 61.32% <ø> (+0.11%) ⬆️
livemode 19.42% <ø> (-0.01%) ⬇️
pcap 44.42% <ø> (-0.01%) ⬇️
suricata-verify 62.71% <ø> (+0.01%) ⬆️
unittests 59.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini
Copy link
Contributor Author

Realized that a few things were missing (and found a few broken things, too) >__<'
Next: #12114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/doc update No code change : only doc or typo fixes
Development

Successfully merging this pull request may close these issues.

2 participants