ndpi plugin support/v5 - fuzz fix test #12109
Closed
+803
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For library users and plugins that need to hook into the thread life cycle, perhaps to initialize some thread storage.
Provide a way for library/plugin users to register a callback that will be called prior to an EVE record being closed. The callback will be passed ThreadVars, Packet, and Flow pointers if available, as well as private user data.
Needed for changes to output-eve.h.
Allows initialization to be done early, so the table is ready for dynamic registration by plugins which are loaded before signature setup.
rust-bindings.h was not being installed with "make install-headers", and its now pulled in by a header used for plugin support, so make sure its installed. We first attempt to install the "dist" version if exists, otherwise install the "gen" one. Also install the "gen" even if the "dist" one exists, as its going to be newer.
jasonish
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12109 +/- ##
==========================================
+ Coverage 83.23% 83.26% +0.02%
==========================================
Files 906 909 +3
Lines 257647 257861 +214
==========================================
+ Hits 214458 214698 +240
+ Misses 43189 43163 -26
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23301 |
|
Why is this a draft? |
Test PR to see if GitHub CI passes. Don't have local setup for cifuzz. |
It passed. |
jasonish
changed the title
victorjulien
approved these changes
Nov 12, 2024
This was referenced Nov 12, 2024
Closed
Merged
|
Merged in #12117, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #12093 with fix for fuzz code compile error.