detect/transforms: write directly in inspect buffer (backport7) #12100
+65
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of writing to a temporary buffer and then copying, to save the cost of copying. Ticket: 7229 Not a cherry-pick as we do not put the transforms in rust, but just do this optimization in C
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12100 +/- ##
==============================================
- Coverage 83.42% 83.26% -0.16%
==============================================
Files 922 922
Lines 260795 260822 +27
==============================================
- Hits 217558 217168 -390
- Misses 43237 43654 +417
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23290 |
victorjulien
requested changes
Nov 8, 2024
| @@ -1654,10 +1654,10 @@ void InspectionBufferFree(InspectionBuffer *buffer) | |||
| * \brief make sure that the buffer has at least 'min_size' bytes | |||
| * Expand the buffer if necessary | |||
| */ | |||
There was a problem hiding this comment.
should add explanation of return value
| return buffer->buf; | ||
| } | ||
|
|
||
| void InspectionBufferTruncate(InspectionBuffer *buffer, uint32_t buf_len) |
| @@ -111,7 +111,11 @@ static void TransformCompressWhitespace(InspectionBuffer *buffer, void *options) | |||
| return; | |||
| } | |||
|
|
|||
| uint8_t output[input_len]; // we can only shrink | |||
| // we can only shrink | |||
| uint8_t *output = (uint8_t *)InspectionBufferCheckAndExpand(buffer, input_len); | |||
There was a problem hiding this comment.
why do we need the cast, instead of updating InspectionBufferCheckAndExpand to return uint8_t *?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7306
Describe changes:
No cherry-pick, but reusing logic in C instead of rust ;-)