Add frontend #16
Merged
Add frontend #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
抱歉最近比较忙没有review，我今天看一下 |
Enter-tainer
reviewed
Aug 2, 2024
shaokeyibb
force-pushed
the
hikarilan
branch
2 times, most recently
from
f0d8049
to
5c39aa3
Compare
|
本地玩了一下新版 感觉挺好的。看到一些小问题：
|
shaokeyibb
force-pushed
the
hikarilan
branch
4 times, most recently
from
699d128
to
deaedbe
Compare
|
一个小问题，我发现有时候点这个按钮会没有用。排查了一下发现是这个按钮的点击区太小了，只有图标是可以点的。这里还有个hover弹出的动画，就会容易点不到。maybe可以考虑优化一下 |
不太好改，因为这里是一个通用的组件，只有按钮那块能响应事件... 其实我也注意到这个问题了，所以我专门把这个 hover 动画的幅度改小了些。个人感觉问题不大，实在不行就把 hover 给删了，我是觉得好看才加的（ |
|
我们先把hover动画删了吧~ |
Enter-tainer
approved these changes
Aug 8, 2024
Enter-tainer
reviewed
Aug 8, 2024
|
找了一圈没找到比较合适的包，索性直接手动 inline 了，这是前后的包体积对比： |
|
是否可以考虑 U+1F5E8 或者 U+1F4AC？ |
那这个得考虑到不同设备（字体）的展示效果问题了，个人不建议 |
|
14k变4k了，挺好的 👍 |
Enter-tainer
reviewed
Aug 8, 2024
Enter-tainer
reviewed
Aug 8, 2024
| import { GetCommentBody, GetCommentRespBody, PostCommentBody, PutCommitHashBody, ResponseBody } from './types'; | ||
| import { getComment, postComment } from './db'; | ||
| import { validateSecret, setCommitHash, compareCommitHash } from './administration'; | ||
| import { matchCommentCache, purgeAllCommentCache, purgeCommentCache, putCommentCache } from './cache'; | ||
|
|
||
| const router = AutoRouter(); | ||
| const { preflight, corsify } = cors({ | ||
| origin: 'https://oi-wiki.org', |
There was a problem hiding this comment.
突然想到一个问题，我们还有一堆镜像站.. https://oi.wiki/intro/mirrors/ 要不把这个list里面的都加上
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add frontend project, use
yarn devfor test (Vite will proxy local cloudflare-worker server to/apipath).Usage:
Import
review.jsas ES Module, then callsetupReviewwith options.Other changes: