Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform fixes, documentation updates and other small stuff #405

Merged
merged 40 commits into from
Feb 26, 2024

Commits on Jul 10, 2023

  1. Configuration menu
    Copy the full SHA
    4dab6b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    5229d73 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0f85fb View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    1fd513c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Use Java 17 for compilation, updates of test dependencies, update lic…

    …ense validation config
    janblom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7c68c3a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    9914a7d View commit details
    Browse the repository at this point in the history
  2. Cleanup

    janblom committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    bcea118 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f539336 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Add generating fat jars for WhiteRabbit and RabbitInAHat; lock hsqldb…

    … version for Java 1.8
    janblom committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0bc3762 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1430457 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Configuration menu
    Copy the full SHA
    90d9fe1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de73c44 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Configuration menu
    Copy the full SHA
    4e530f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5a78bd View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Update main.yml

    Project now requires Java 17 to build. Should still produce java 8 (1.8) compatible artifacts though.
    janblom authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    56cdb66 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Merge pull request #32 from thehyve/license-compliance

    License compliance
    janblom authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d6d56b4 View commit details
    Browse the repository at this point in the history
  2. Bump org.apache.avro:avro from 1.11.2 to 1.11.3 in /rabbit-core

    Bumps org.apache.avro:avro from 1.11.2 to 1.11.3.
    
    ---
    updated-dependencies:
    - dependency-name: org.apache.avro:avro
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0888764 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #33 from thehyve/dependabot/maven/rabbit-core/org.…

    …apache.avro-avro-1.11.3
    
    Bump org.apache.avro:avro from 1.11.2 to 1.11.3 in /rabbit-core
    janblom authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    290f9f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Configuration menu
    Copy the full SHA
    0ed7a93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d591898 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9f9344 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #34 from thehyve/distribution-integration-test

    Distribution integration test
    janblom authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f26d572 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    4f43f5b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Update stem table image

    Spayralbe committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    20697d5 View commit details
    Browse the repository at this point in the history
  2. Decrease size of table panel when using stem table.

    Without this change, the table panel height is always higher than
    needed (when using stem table), because the stem table is counted
    as one of the items in the components list. It is however shown
    separately at the top, which is already accounted for by the
    stem table margin.
    Spayralbe committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    5c34665 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Add snowflake support (#37)

    * Refactor RichConnection into separate classes, and add an abstraction for the JDBC connection. Implement a Snowflake connection with this abstraction
    
    * Add unit tests for SnowflakeConnector
    
    * Added Snowflake support for SourceDataScan; added minimal test for it; some refactorings to move database responsibility to rabbit-core/databases
    
    * Move more database details to rabbit-core/databases
    
    * Clearer name for method
    
    * Ignore snowflake.env
    
    * Create PostgreSQL container in the TestContainers way
    
    * Refactored Snowflake tests + a bit of documentation
    
    * Fix Snowflake test for Java 17, and make it into an automated integration test instead of a unit test
    
    * Remove duplicate postgresql test
    
    * Make TestContainers based database tests into automated integration tests
    
    * Suppress some warnings when generating fat jars
    
    * Let autimatic integration tests fail when docker is not available
    
    * Allow explicit skipping of Snowflake integration tests
    
    * Added tests for Snowflake, delimited text files
    
    * Switch to fully verifying the scan results against a reference version (v0.10.7)
    
    * Working integration test for Snowflake, and some refactorings
    
    * Some proper logging, small code improvements and cleanup
    
    * Remove unused interface
    
    * Added tests, some changes to support testing
    
    * Make automated test work reliably (way too many changes, sorry)
    
    * Rudimentary support for Snowflake authenticator parameter (untested)
    
    * review xmlbeans dependencies, remove conflict
    
    * extend integration test for distribution
    
    * Restructuring database configuration. Work in process, but unit and integration tests all OK
    
    * Restructuring database configuration 2/x. Still work in process, but unit and integration tests all OK
    
    * Restructuring database configuration 3/x. Still work in process, but unit and integration tests all OK
    
    * Restructuring database configuration 4/x. Still work in process, but unit and integration tests all OK
    
    * Restructuring database configuration 5/x. Still work in process, but unit and integration tests all OK
    
    * Restructuring database configuration 6/x. Still work in process, but unit and integration tests all OK
    
    * Restructuring database configuration 7/x. Still work in process, but unit and integration tests all OK
    
    * Intermezzo: get rid of the package naming error (upper case R in whiteRabbit)
    
    * Intermezzo: code cleanup
    
    * Snowflake is now working from the GUI. And many small refactorings, like logging instead of printing to stout/err
    
    * Refactor DbType into an enum, get rid of DBChoice
    
    * Move DbType and DbSettings classes into configuration subpackage
    
    * Avoid using a manually destructured DbSettings object when creating a RochConnection object
    
    * Code cleanup, remove unneeded Snowflake references
    
    * Refactoring, code cleanup
    
    * More refactoring, code cleanup
    
    * More refactoring, code cleanup and documentation
    
    * Make sure that order of databases in pick list in GUI is the same as before, and enforce completeness of that list in a test
    
    * Add/update copyright headers
    
    * Add line to verify that a tooltip is shown for a DBConnectionInterface implementing class
    
    * Test distribution for Snowflake JDBC issue with Java 17
    
    * cleanup of build files
    
    * Add verification that all JDBC drivers are in the distributed package
    
    * Add/improve error reporting for Snowflake
    
    * Disable screenshottaker in GuiTestExtension, hoping that that is what blocks the build on github. Fingers crossed
    
    * Better(?) naming for database interface and implementing class
    
    * Use our own GUITestExtension class
    
    ---------
    
    Co-authored-by: Jan Blom <[email protected]>
    janblom and jan-at-the-hyve authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    7baa4ed View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Merge pull request #36 from thehyve/riah-stem-docs

    Update stem table image
    Spayralbe authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e6ba99e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #35 from thehyve/stem-table-image-size

    Fix image crop when using stem table
    Spayralbe authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    cbca299 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Configuration menu
    Copy the full SHA
    7dd23d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Add mysql test (#38)

    * Fixed a bug in the comparison for sort; let comparison report report all differences before failing
    
    * Allow the user to specify the port for a MySQL server
    
    * Add tests for a MySQL source database
    janblom authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f1dada2 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Add sas test (#39)

    * Add automated regression tests for SAS files
    
    * Fix problems with comparisons of test results to references
    
    * create bypass for value mismatch that only shows up in github actions so far
    
    * create bypass for value mismatch that only shows up in github actions so far, 2nd
    janblom authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    60726a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    a2b78be View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Prepare release (#40)

    * Add warehouse/database handling to StorageHandler class
    
    * Show stdout/stderr from distribution verification when there are errors
    
    * Pom updates to enable building on MacOS
    
    * Update dependencies as far as possible without code changes
    
    * Update README.md
    
    ---------
    
    Co-authored-by: Jan Blom <[email protected]>
    janblom and jan-at-the-hyve authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    93e68a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Update whiterabbit/src/main/java/org/ohdsi/whiterabbit/WhiteRabbitMai…

    …n.java
    
    
    The sample size should start disabled, as the calculateNumericStats checkbox is unchecked by default.
    
    Co-authored-by: Maxim Moinat <[email protected]>
    janblom and MaximMoinat authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    3d35075 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4cbc472 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Fixes from windows (#41)

    * Fix problems blocking verification on Windows
    
    * Avoid using bind mounts for TestContainers, copy files instead
    
    * Remove file copy (was for debugging purposes)
    
    * Oracle Tests: use the actual TestContainer hostname/ip address instead of localhost
    
    * Remove debug print statement and stale imports
    
    * Remove commented code
    
    ---------
    
    Co-authored-by: Jan Blom <[email protected]>
    janblom and jan-at-the-hyve authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5613707 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    d234b77 View commit details
    Browse the repository at this point in the history
  2. Use The Hyve fork of the caciocavello project (#42)

    * Use The Hyve fork of the caciocavello project (Swing virtual graphics environment for testing) until the parent project has been fixed for JDK 18+
    
    * Use updated cacio-tta version, should run fine when headless
    
    * For developemnt, JDK versions 17-21 are supported
    janblom authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    f73e34d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    1a35c0f View commit details
    Browse the repository at this point in the history
  2. Update docs (#44)

    * Update documentation for Snowflake
    
    * Add Snowflake.ini example file
    
    * Add password field in Snowflake example
    janblom authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f862492 View commit details
    Browse the repository at this point in the history