Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drug end date convention #694

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

MaximMoinat
Copy link
Collaborator

@MaximMoinat MaximMoinat commented Jun 6, 2024

As noted by @MelaniePhilofsky: the drug end date convention is now on Themis, and there is no need to repeat it here.

  • Shorten paragraph on drug end date from v5.3 and v5.4 and v6.0 field level csv
  • Render html.

@MaximMoinat MaximMoinat marked this pull request as ready for review June 10, 2024 07:18
@MaximMoinat
Copy link
Collaborator Author

@clairblacketer When I execute rmarkdown::render_site(), it completes but the tables with field description do not render in the cdm53 and cdm54 documentation. Could you try?

@MaximMoinat
Copy link
Collaborator Author

MaximMoinat commented Jun 14, 2024

@clairblacketer I was able to render the pages using the 'knit' button directly in RStudio.

As discussed in Yesterday's meeting, this is just a small start for a bigger documentation refactoring. Other descriptions should also be shortened (e.g. in drug exposure the drug_concept_id, quantity and days_supply fields are still full paragraphs of convention description which might be covered by our new Themis library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants