Choose SIMD implementation at cmake time #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah! I forgot that was the problem. It IS acceptable to rename each implementation-specific file (e.g. append a suffix) so that naming becomes unique. |
|
Not completely related, but would it be ok to rename: This seems to be the convention used for other files and would resolve conflicting names with the file: |
eugenegff
force-pushed
the
master
branch
2 times, most recently
from
3904aa1
to
da6dbf9
Compare
darksylinc
force-pushed
the
master
branch
4 times, most recently
from
76d820e
to
03fbfb6
Compare
eugenegff
force-pushed
the
master
branch
2 times, most recently
from
2ee1c83
to
8b3ddcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A less drastic version of #157 (this doesn't delete proxy files or change folder structure). A motivating factor behind deleting the proxy files was to prevent multiple files having the same name so that ninja/vcpkg/Xcode would not complain, although this doesn't seem to be an issue anymore with the changes I've made.
This PR merges both the OGRE_SIMD_SSE2 and OGRE_SIMD_NEON flags into a single flag OGRE_SIMD, and CMake is now responsible for picking SSE2, NEON or C.