Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-2138 NZSL Upgrade Django 3.2.25 > 4.2 #170

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jonholdsworth
Copy link

@jonholdsworth jonholdsworth self-assigned this Jun 13, 2024
@jonholdsworth jonholdsworth marked this pull request as draft June 13, 2024 06:17
@jonholdsworth
Copy link
Author

jonholdsworth commented Jun 14, 2024

Some things

  • I've unpinned pretty much all the requirements.txt dependencies, as this is a large version jump and there didn't seem much point. Plus I hit some compatibility issues with the pinnings and was not about to waste hours/days. If there are any you think should be pinned for whatever reason please specify. Similarly, if you think I should release the remaining pinnings or update them.
  • DATABASES is now a strict requirement. Somewhere around Django 4.1 -> 4.2 the requirement for this variable changed and its format became stricter. The Django docs are unfocussed around this. The short form is that collectstatic would not run in a local dev environment unless DATABASE_URL was defined - as this is used to create DATABASES - and DATABASE_URL is not defined that early. An alternative is make the setup define DATABASE_URL if it is not defined, instead of doing that for DATABASES. Whichever is felt to be neater.

@jonholdsworth jonholdsworth marked this pull request as ready for review June 14, 2024 03:25
@jonholdsworth jonholdsworth requested review from G-Rath and nzlaura June 14, 2024 03:27
Copy link

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has also reminded me about moving to Poetry 😄 feel free to do that even before we land this PR if it'd make it easier

requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
signbank/settings/base.py Show resolved Hide resolved
@jonholdsworth jonholdsworth requested a review from G-Rath June 14, 2024 04:58
Copy link

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets move to Poetry first

@jonholdsworth jonholdsworth marked this pull request as draft June 14, 2024 05:08
@jonholdsworth
Copy link
Author

Reverting back to Draft until Poetry conversion completed.

@jonholdsworth jonholdsworth marked this pull request as ready for review June 21, 2024 07:39
@jonholdsworth jonholdsworth requested a review from G-Rath June 21, 2024 07:39
@jonholdsworth
Copy link
Author

And here we are in Poetry land.
Take a look, see what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants