Use preprocessed OGGM data and migrate to pure Julia instead of relying on PyCall #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ongoing fix, still a few lines missing, and tests have still not been run.
* migrate all 2D files to purejulia * update test references * remove PyCall dependencies in the 1D files * automatic download of preprocessed data + remove DataFrames dependency * try to remove Python from the CI * remove remaining implicit dependencies to Python objects * create get_rgi_paths * fix various bugs * remove absolute paths from get_rgi_paths to make the tests platform agnostic * fix bugs with the climate_2D_step structure * some cleaning * bump version
albangossard
force-pushed
the
purejulia
branch
from
7e113ca to
f7fdbc1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 38.02% 29.51% -8.51%
==========================================
Files 16 15 -1
Lines 697 603 -94
==========================================
- Hits 265 178 -87
+ Misses 432 425 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OGGM data are now preprocessed using https://github.com/ODINN-SciML/Gungnir. This allows us to get rid of PyCall and use pure Julia instead.