fix the glathida processing part

ODINN-SciML · Jan 25, 2025 · 18f11b8 · 18f11b8
1 parent 155166b
commit 18f11b8
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 17 deletions.
diff --git a/src/glaciers/glacier/glacier2D_utils.jl b/src/glaciers/glacier/glacier2D_utils.jl
@@ -36,7 +36,7 @@ function initialize_glaciers(rgi_ids::Vector{String}, params::Parameters; test=f
         pmap((rgi_id) -> generate_raw_climate_files(rgi_id, params.simulation), rgi_ids)
     end
 
-    glaciers = pmap((rgi_id) -> initialize_glacier(rgi_id, params; smoothing=false, test=test), rgi_ids)
+    glaciers::Vector{Glacier2D} = pmap((rgi_id) -> initialize_glacier(rgi_id, params; smoothing=false, test=test), rgi_ids)
 
     if params.simulation.use_glathida_data == true
 
@@ -86,11 +86,6 @@ function initialize_glacier(rgi_id::String, parameters::Parameters; smoothing=fa
     # Initialize glacier climate
     initialize_glacier_climate!(glacier, parameters)
 
-    if test
-        glacier.rgi_id = nothing # not sure of that line
-        glacier.S_coords = nothing
-    end
-
     return glacier
 end
 
@@ -193,23 +188,23 @@ function get_glathida!(glaciers::Vector{Glacier2D}, params::Parameters; force=fa
 end
 
 function get_glathida_glacier(glacier::Glacier2D, params::Parameters, force)
-    rgi_path = joinpath(prepro_dir, params.simulation.rgi_paths[rgi_id])
+    rgi_path = joinpath(prepro_dir, params.simulation.rgi_paths[glacier.rgi_id])
     gtd_path = joinpath(rgi_path, "glathida.h5")
     if isfile(gtd_path) && !force
         gtd_grid = h5read(gtd_path, "gtd_grid")
     else
-        glathida = CSV.File(joinpath(rgi_path, "glathida.csv"))
+        glathida = CSV.File(joinpath(rgi_path, "glathida_data.csv"))
         gtd_grid = zeros(size(glacier.H₀))
         count = zeros(size(glacier.H₀))
-        for (thick, i, j) in zip(glathida["elevation"], glathida["i_grid"], glathida["j_grid"])
+        for (thick, i, j) in zip(glathida["thickness"], glathida["i_grid"], glathida["j_grid"])
             count[i,j] += 1
             gtd_grid[i,j] += thick
         end
 
-        gtd_grid .= ifelse.(count > 0, gtd_grid ./ count, 0.0)
+        gtd_grid .= ifelse.(count .> 0, gtd_grid ./ count, 0.0)
 
         # Save file
-        h5open(joinpath(prepro_dir, params.simulation.rgi_paths[glacier.rgi_id], "glathida.h5"), "w") do file
+        h5open(joinpath(rgi_path, "glathida.h5"), "w") do file
             write(file, "gtd_grid", gtd_grid)
         end
     end

diff --git a/test/data/glaciers/glaciers2D_w_glathida.jld2 b/test/data/glaciers/glaciers2D_w_glathida.jld2
diff --git a/test/data/glaciers/glaciers2D.jld2 → ...data/glaciers/glaciers2D_wo_glathida.jld2 b/test/data/glaciers/glaciers2D.jld2 → ...data/glaciers/glaciers2D_wo_glathida.jld2
diff --git a/test/data/params/params_specified.jld2 b/test/data/params/params_specified.jld2
diff --git a/test/data/params/simulation_params_specified.jld2 b/test/data/params/simulation_params_specified.jld2
diff --git a/test/glaciers_construction.jl b/test/glaciers_construction.jl
@@ -1,23 +1,31 @@
 
 
-function glaciers2D_constructor(; save_refs::Bool = false)
+function glaciers2D_constructor(; save_refs::Bool = false, use_glathida_data::Bool = false)
 
     rgi_paths = get_rgi_paths()
-    rgi_ids = ["RGI60-11.03638", "RGI60-11.01450"]
+    if use_glathida_data
+        rgi_ids = ["RGI60-07.00042", "RGI60-07.00065"] # Use glaciers that have glathida data
+        file_suffix = "w_glathida"
+    else
+        rgi_ids = ["RGI60-11.03638", "RGI60-11.01450"]
+        file_suffix = "wo_glathida"
+    end
+    # Filter out glaciers that are not used to avoid having references that depend on all the glaciers processed in Gungnir
+    rgi_paths = Dict(k => rgi_paths[k] for k in rgi_ids)
 
     params = Parameters(simulation=SimulationParameters(velocities=false,
-                                                        use_glathida_data=false,
+                                                        use_glathida_data=use_glathida_data,
                                                         working_dir=Sleipnir.root_dir,
                                                         test_mode=true,
                                                         rgi_paths=rgi_paths))
 
     glaciers = initialize_glaciers(rgi_ids, params; test=true)
 
     if save_refs
-        jldsave(joinpath(Sleipnir.root_dir, "test/data/glaciers/glaciers2D.jld2"); glaciers)
+        jldsave(joinpath(Sleipnir.root_dir, string("test/data/glaciers/glaciers2D_", file_suffix, ".jld2")); glaciers)
     end
 
-    glaciers_ref = load(joinpath(Sleipnir.root_dir,"test/data/glaciers/glaciers2D.jld2"))["glaciers"]
+    glaciers_ref = load(joinpath(Sleipnir.root_dir, string("test/data/glaciers/glaciers2D_", file_suffix, ".jld2")))["glaciers"]
 
     @test all(glaciers == glaciers_ref)
 

diff --git a/test/params_construction.jl b/test/params_construction.jl
@@ -1,7 +1,10 @@
 
 function params_constructor_specified(; save_refs::Bool = false)
 
+    rgi_id = "RGI60-11.03638"
     rgi_paths = get_rgi_paths()
+    # Filter out glaciers that are not used to avoid having references that depend on all the glaciers processed in Gungnir
+    rgi_paths = Dict(rgi_id => rgi_paths[rgi_id])
 
     physical_params = PhysicalParameters(ρ = 900.0,
                                         g = 9.81,

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -21,6 +21,8 @@ ENV["GKSwstype"]="nul"
 
 @testset "Parameters constructors by default" params_constructor_default()
 
-@testset "Glaciers 2D constructors" glaciers2D_constructor()
+@testset "Glaciers 2D constructors w/o glathida data" glaciers2D_constructor(use_glathida_data=false)
+
+@testset "Glaciers 2D constructors w/ glathida data" glaciers2D_constructor(use_glathida_data=true)
 
 #@testset "Glaciers 2D plots" glaciers2D_plots()