-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plotting function to check influence of flow parameters A and n #39
Conversation
Added plotting function to see influence of flow parameters A and n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just a few comments to modify some little things. Mark them as solved and I will run the test and integrate it.
The tests are still failing, however this should be fixed once Sleipnir is up to date with the recent changes and Sleipnir is updated within Huginn. Locally with the new Sleipnir all test pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vivekag7. Please do these minor changes, and I will merge your PR and include it in the Huginn release I'll make today for ODINN's new architecture. Thanks!
Made another small change next to the requested fixes: I made sure the new plotting utility plot_analysis_flow_parameters() uses a Sleipnir.parameters object as an input. Several reasons why I did this:
Tested it locally and everything worked, so if everything is right it should work on github. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage ? 92.23%
=======================================
Files ? 10
Lines ? 399
Branches ? 0
=======================================
Hits ? 368
Misses ? 31
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Note: only works with Sleipnir v0.4.0 + Muninn v0.2.6 + GlaThiDa update
Added plotting function to check influence of flow parameters A and n.
A_values
andn_values
each should not exceed 5).rgi_ids
should be 1).Usage of iceflow and mass balance can also be specified, according to your preference. The default is set to true.
See below an example plot:
Note that the colorbar is the same for each plot, which makes it easy to compare.