Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixify superbol-free for dev #380

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

emilienlemaire
Copy link
Contributor

No description provided.

Copy link
Contributor

@krtab krtab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

let
inherit (pkgs) lib ocamlPackages;
version = "dev"; /*TODO: Edit*/
src = lib.cleanSource ./.;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD if we really want to pull all source files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do because of submodules 😭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(aka my nemesis)

ppx_import
];

/* Used to build generated OCaml files */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this a bit more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files are generated from the menhir grammar (like error recovery or keywords data types) to avoid having to edit them by hand when updating the grammar.
But when compiling the grammar in nix, some values were renamed and didn't match the generated files, and dune does not seem to regenerate them by default, I added these lines so they are regenerated every time (there might be other solutions, but this one works for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants