Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a datum_conf.c check for no pool, but mining only #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jesterhodl
Copy link
Contributor

This attempts to address @wizkid057's issue #38

@luke-jr luke-jr added the bug Something isn't working label Dec 14, 2024
@luke-jr luke-jr added this to the v0.2.2 milestone Dec 14, 2024
src/datum_conf.c Outdated
DLOG_FATAL("Pooled mining only is set to true, but pool host is not specified.");
return 0;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you indent this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash it in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's squashed now

@jesterhodl jesterhodl force-pushed the non-pooled-mining-inconsistency branch from cb7bdc0 to 10460f1 Compare December 14, 2024 18:24
@luke-jr
Copy link
Contributor

luke-jr commented Dec 14, 2024

Commit description is confusing.

Maybe something like:

conf: Refuse to start with pooled mining only, if there's no pool set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants