Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] web_select_all_companies: Backporting from 15.0 to 14.0 #2938

Merged
merged 7 commits into from
Oct 24, 2024

Conversation

ajaniszewska-dev
Copy link

@ajaniszewska-dev ajaniszewska-dev commented Sep 27, 2024

No description provided.

@ajaniszewska-dev ajaniszewska-dev changed the title 14 mig web select all companies [MIG] web_select_all_companies: Backporting from 15.0 to 14.0 Sep 27, 2024
@ajaniszewska-dev ajaniszewska-dev force-pushed the 14-mig-web_select_all_companies branch 4 times, most recently from 0a43388 to f9d48ea Compare October 15, 2024 13:16
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check pre-commit?

@twalter-c2c twalter-c2c force-pushed the 14-mig-web_select_all_companies branch from f9d48ea to 603cbf3 Compare October 18, 2024 10:18
@twalter-c2c
Copy link

@ivantodorovich pre-commit fixed

Copy link

@florentx florentx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for an improvement, after feedback from a user.

Copy link

@florentx florentx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, and works fine

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk simahawk added this to the 14.0 milestone Oct 24, 2024
@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-2938-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 33bfa51 into OCA:14.0 Oct 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6bf7534. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants