[16.0][IMP] web_timeline - for relational group fields use default order in related model, fix for default_group_by attribute no relational #2929

IJOL · 2024-09-05T11:29:32Z

No description provided.

OCA-git-bot · 2024-09-05T11:29:37Z

Hi @tarteo,
some modules you are maintaining are being modified, check this out!

carlos-lopez-tecnativa · 2024-09-26T15:37:13Z

@IJOL, could you please give me an example or use case to test this PR? Thanks.

TT50999

IJOL · 2024-09-27T11:03:57Z

@IJOL, could you please give me an example or use case to test this PR? Thanks.

TT50999

if your timeline default_group_by field is a many2* field and the related model has a sequence field it used to order the groups in the timeline left area, in the example in https://github.com/OCA/project/blob/16.0/project_timeline/views/project_project_view.xml if you change default_group_by to project_id which i think you can in that context, with my change the sequence field in the project model should be used as order for the groups in the timeline, thus giving the same order in the timeline that projects has

pedrobaeza · 2024-09-27T11:05:32Z

The order should be defined by the model itself with their _order clause, being the sequence or whatever, but it shouldn't be hardcoded. The module should rely on the existing order.

IJOL · 2024-09-27T11:06:34Z

this is exactly what the sequence field does in other contexts like list , trees or whatever, if the group is a model wiith no seuqence, or a plain field it does nothing

pedrobaeza · 2024-09-27T11:09:01Z

That's only if the widget="handle" is present AFAIK, but it's not the same context here, as we can't drag and drop for changing such sequence. I insist that we must rely on the model order.

IJOL · 2024-09-27T11:12:23Z

The problem is that Js part reworks the groups, because your are no reading from a projects query that should be ordered you are doingthe groups by the extension it self, and gives up any order i think in the context i use it, and in the example given you order the group as it is stored in the tasks, so no order in projects at all

IJOL · 2024-09-27T11:23:03Z

Just confused the example i use it in project.task context model and i try to group by project_id..

pedrobaeza · 2024-09-27T11:31:38Z

When grouping by project, you should query Odoo to return the ordered recordset including all the existing projects.

IJOL · 2024-09-27T13:09:01Z

When grouping by project, you should query Odoo to return the ordered recordset including all the existing projects.

Ok, get your point it should be easy to implement that way too, not actually able to remember why i ended in this solution, not so sure i have now the time to do it.. i will push something if i can

pedrobaeza · 2024-09-27T14:56:43Z

Great, let us know. @carlos-lopez-tecnativa FYI

tarteo · 2024-10-01T07:57:15Z

@IJOL are you saying when grouping records, the groups are not ordered by the corresponding model's order?

this is exactly what the sequence field does in other contexts like list , trees or whatever, if the group is a model wiith no seuqence, or a plain field it does nothing

Can you send me a link to where Odoo does this in the tree view etc. Does it there look at hard-coded sequence or _order? Thanks in advance

IJOL · 2024-10-01T08:24:44Z

Actually the js code for extension, only gets the group id from data ( in the examples i put in from tasks and the group_id is the project_id) and if it a relational field gets the name from the corresponding model, but the order is the one obtained from the data, the order in which the groups are named in the data to be exact, mi first proposed change tried to not mess too much with the Js part and simply try to assume that if the related model in the group_id has a sequence field this was the order the group id model was supposed to do, and do nothing in any other case, just a cheap way to do what actually the extension do badly, that is the groups had no order at all, last friday i got convinced by Pedro Baeza to getting the order from the model itself by doing a simple search of all related model data and extract the order from there, as i was assuming naively that the order of the related model comes from a field named sequence in the model.... Saludos, -------------------------------------------- Ignacio J.Ortega skype:ignacioj.ortega El mar, 1 oct 2024 a las 9:57, Dennis Sluijk ***@***.***>) escribió:

…

@IJOL <https://github.com/IJOL> are you saying when grouping records, the groups are not ordered by the corresponding model's order? this is exactly what the sequence field does in other contexts like list , trees or whatever, if the group is a model wiith no seuqence, or a plain field it does nothing Can you send me a link to where Odoo does this in the tree view etc. Does it there look at hard-coded sequence or _order? Thanks in advance — Reply to this email directly, view it on GitHub <#2929 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHYV754KFAPHOFAOWWP53ZZJIXBAVCNFSM6AAAAABNWI4FPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBVGA2TKMJTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

IJOL · 2024-10-17T07:42:15Z

As suggested the group's order is obtained from the related model if the default_group_by is relational ( Many2one or Many2many ), i added a fix for other issues i'm having when the group field if is not relational, need reviewers though..

@carlos-lopez-tecnativa @tarteo @pedrobaeza

pedrobaeza · 2024-10-19T06:25:27Z

ping @carlos-lopez-tecnativa

carlos-lopez-tecnativa

Functionally tested, and it works. Just a minor technical change needed for performance reasons.

carlos-lopez-tecnativa · 2024-11-06T12:57:28Z

web_timeline/static/src/js/timeline_renderer.js

+            const fields = await this._rpc({
+                model: this.modelName,
+                method: "fields_get",
+                args: [[grouped_field]],
+                context: this.getSession().user_context,
+            });
+            const fieldType = fields[grouped_field].type;
+            const relation = fields[grouped_field].relation;


I think this RPC call can be avoided if you use this.fields, which already contains metadata for fields (such as type, relation, etc.).

Suggested change

const fields = await this._rpc({

model: this.modelName,

method: "fields_get",

args: [[grouped_field]],

context: this.getSession().user_context,

});

const fieldType = fields[grouped_field].type;

const relation = fields[grouped_field].relation;

const fieldType = this.fields[grouped_field].type;

const relation = this.fields[grouped_field].relation;

Thank you, good catch!!

carlos-lopez-tecnativa

LGTM

carlos-lopez-tecnativa · 2024-11-08T12:07:03Z

ping @pedrobaeza

pedrobaeza · 2024-11-08T12:19:34Z

web_timeline/static/src/js/timeline_controller.esm.js

+                views: [[false, "form"]],
+            });
+        }
+        console.warn(`Field ${groupField} is not a relational field.`);


Remove this

pedrobaeza · 2024-11-08T12:20:06Z

web_timeline/README.rst

@@ -2,7 +2,7 @@
 Web timeline
 ============

-.. 
+..


These changes seem to be done by the IDE stripping out leading spaces. They should be removed.

pedrobaeza · 2024-11-08T12:20:15Z

web_timeline/static/description/index.html

@@ -8,11 +8,10 @@

 /*
 :Author: David Goodger ([email protected])
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $


This also shouldn't change.

I dont know how that change was done, but it seems legit to me, maybe is the precommit thing..

Yeah, because you have a different libraries than the bot, but it will be undone again by the bot. I was trying to avoid noise.

…th a relational field in addition fixes grouping when the field is not relational, and default_group_by can use a non relational field

legalsylvain changed the title ~~[18.0][IMP] if the group field is relational try to use sequence field in related model if it exists~~ [16.0][IMP] if the group field is relational try to use sequence field in related model if it exists Sep 5, 2024

IJOL force-pushed the 16.0-web_timeline-groups-sequence branch 3 times, most recently from 0c3272a to 360e8af Compare September 5, 2024 15:47

pedrobaeza added this to the 16.0 milestone Sep 5, 2024

IJOL changed the title ~~[16.0][IMP] if the group field is relational try to use sequence field in related model if it exists~~ [16.0][IMP] web_timeline - if the group field is relational try to use sequence field in related model if it exists Sep 5, 2024

IJOL force-pushed the 16.0-web_timeline-groups-sequence branch from 157eca7 to bda41fc Compare September 5, 2024 16:19

IJOL force-pushed the 16.0-web_timeline-groups-sequence branch 2 times, most recently from 328f853 to eb862c9 Compare October 16, 2024 15:07

IJOL changed the title ~~[16.0][IMP] web_timeline - if the group field is relational try to use sequence field in related model if it exists~~ [16.0][IMP] web_timeline - for relational group fields use default order in related model, fix for default_group_by attribute no relational Oct 16, 2024

IJOL force-pushed the 16.0-web_timeline-groups-sequence branch from eb862c9 to 2114bfa Compare October 16, 2024 16:13

IJOL force-pushed the 16.0-web_timeline-groups-sequence branch 2 times, most recently from 832c06a to 1592ce8 Compare October 17, 2024 09:19

carlos-lopez-tecnativa suggested changes Nov 6, 2024

View reviewed changes

IJOL force-pushed the 16.0-web_timeline-groups-sequence branch from 1592ce8 to 44a7b0a Compare November 7, 2024 10:45

IJOL requested a review from carlos-lopez-tecnativa November 7, 2024 11:48

carlos-lopez-tecnativa approved these changes Nov 7, 2024

View reviewed changes

pedrobaeza reviewed Nov 8, 2024

View reviewed changes

[IMP] web_timeline: Uses model order when using a default_group_by wi…

916e166

…th a relational field in addition fixes grouping when the field is not relational, and default_group_by can use a non relational field

IJOL force-pushed the 16.0-web_timeline-groups-sequence branch from 44a7b0a to 916e166 Compare November 11, 2024 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][IMP] web_timeline - for relational group fields use default order in related model, fix for default_group_by attribute no relational #2929

[16.0][IMP] web_timeline - for relational group fields use default order in related model, fix for default_group_by attribute no relational #2929

IJOL commented Sep 5, 2024

OCA-git-bot commented Sep 5, 2024

carlos-lopez-tecnativa commented Sep 26, 2024

IJOL commented Sep 27, 2024 •

edited

Loading

pedrobaeza commented Sep 27, 2024

IJOL commented Sep 27, 2024 •

edited

Loading

pedrobaeza commented Sep 27, 2024

IJOL commented Sep 27, 2024 •

edited

Loading

IJOL commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

IJOL commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

tarteo commented Oct 1, 2024

IJOL commented Oct 1, 2024 via email

IJOL commented Oct 17, 2024

pedrobaeza commented Oct 19, 2024

carlos-lopez-tecnativa left a comment

carlos-lopez-tecnativa Nov 6, 2024

IJOL Nov 7, 2024

carlos-lopez-tecnativa left a comment

carlos-lopez-tecnativa commented Nov 8, 2024

pedrobaeza Nov 8, 2024

pedrobaeza Nov 8, 2024

pedrobaeza Nov 8, 2024

IJOL Nov 8, 2024

pedrobaeza Nov 8, 2024

[16.0][IMP] web_timeline - for relational group fields use default order in related model, fix for default_group_by attribute no relational #2929

Are you sure you want to change the base?

[16.0][IMP] web_timeline - for relational group fields use default order in related model, fix for default_group_by attribute no relational #2929

Conversation

IJOL commented Sep 5, 2024

OCA-git-bot commented Sep 5, 2024

carlos-lopez-tecnativa commented Sep 26, 2024

IJOL commented Sep 27, 2024 • edited Loading

pedrobaeza commented Sep 27, 2024

IJOL commented Sep 27, 2024 • edited Loading

pedrobaeza commented Sep 27, 2024

IJOL commented Sep 27, 2024 • edited Loading

IJOL commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

IJOL commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

tarteo commented Oct 1, 2024

IJOL commented Oct 1, 2024 via email

IJOL commented Oct 17, 2024

pedrobaeza commented Oct 19, 2024

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

carlos-lopez-tecnativa Nov 6, 2024

Choose a reason for hiding this comment

IJOL Nov 7, 2024

Choose a reason for hiding this comment

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

carlos-lopez-tecnativa commented Nov 8, 2024

pedrobaeza Nov 8, 2024

Choose a reason for hiding this comment

pedrobaeza Nov 8, 2024

Choose a reason for hiding this comment

pedrobaeza Nov 8, 2024

Choose a reason for hiding this comment

IJOL Nov 8, 2024

Choose a reason for hiding this comment

pedrobaeza Nov 8, 2024

Choose a reason for hiding this comment

IJOL commented Sep 27, 2024 •

edited

Loading

IJOL commented Sep 27, 2024 •

edited

Loading

IJOL commented Sep 27, 2024 •

edited

Loading