[16.0][ADD] web_widget_remaining_days_exact_date: New module to show exact date when remaining days shown #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
approved these changes
Aug 14, 2024
| { | ||
| get diffString() { | ||
| var value = this._super(...arguments); | ||
| if (this.props.exact_date && Math.abs(this.diffDays) <= 99) { |
There was a problem hiding this comment.
Add comment on why the hardcoded 99 value :)
…date when remaining days shown This module is adding an option to the remaining_days widget to be able to show the exact date.
CarlosRoca13
force-pushed
the
16.0-ADD-web_widget_remaining_days_exact_date
branch
from
9cf8e43
to
a2f4298
Compare
|
I have changed the module's behavior so that this option works by default, and in case you don't want to use it, it can be disabled with options="{'exact_date': False}". Please review it again @chienandalu |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 5cdc126. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is adding an option to the remaining_days widget to be able to show the exact date.
cc @Tecnativa TT50517
ping @pedrobaeza @chienandalu