Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] web_responsive: Remove overflow:visible to tables to avoid side effects #2910

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

victoralmau
Copy link
Member

Remove overflow:visible to tables to avoid side effects

Without web_responsive
sin-web-responsive

With web_responsive - before
antes-web_responsive

With web_responsive - after
despues-web_responsive

Please @CarlosRoca13 can you review it?

@Tecnativa TT50468

@OCA-git-bot
Copy link
Contributor

Hi @SplashS, @Tardo,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 8, 2024

Please check why that was introduced, as maybe removing it has another "side effect". You can ask as well the original contributor.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 8, 2024
@victoralmau
Copy link
Member Author

victoralmau commented Aug 8, 2024

These changes were added at #2405 (I don't know exactly why) and removed at #2684.

Ping @bvanjeelharia Can you tell us why that code was added, is this change correct and will not cause side effects or do you propose a better one? Thanks

@pedrobaeza
Copy link
Member

The ping wasn't correct. Trying again @bvanjeelharia

@pedrobaeza
Copy link
Member

If removed in 17.0, it seems it's not very needed.

@victoralmau
Copy link
Member Author

@pedrobaeza
Copy link
Member

Well, it was removed because Odoo incorporates the sticky feature natively, so maybe the overflow was not removed specifically, but inside that block. Anyway, it looks more and more a side effect.

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2910-by-CarlosRoca13-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8c85f73 into OCA:16.0 Aug 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b9fd7f3. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-web_responsive-TT50468 branch August 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants