[16.0][FIX] web_widget_numeric_step: Remove focus to avoid annoying flickering effect #2909
Conversation
…ing effect The focus introduced on the 16.0 migration is causing a flickering effect that is a bit annoying and does not make complete sense, because if you click more than once the cursor is positioned at the end of the text, which makes it difficult to edit the input. The counterpart of these changes is that to edit the input using the keyboard we will have to click on the field. Although this is how the module has been operating since its inception.
There was a problem hiding this comment.
Oh, I see now that the flickering is a little bit less annoying with the regular theme (I tested it with web_theme_classic installed in the runboat)... In the one hand, we lived without this focus for several versions without noticing it, in the other hand is a nice UX touch...
|
It was changed by @yajo. Let's see the reasons for that change. At first sight, I would say the idea was to click on -/+ and have the focus for refining the amount. If the flickering is not very annoying, we can live with it. |
|
Not really, it was introduced in the migration for v16 and @yajo disabled it for touch devices |
|
Uhm, then it was @dsolanki-initos |
|
I think the focus doesn't contribute much, since in the end, you're going to have to position the cursor where you want to modify the value. Also, I think the module's scope isn't meant to cover the need to manually modify the input... That's what the buttons and the scroll are for. Don't you think the same? |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 3760f16. Thanks a lot for contributing to OCA. ❤️ |
The focus introduced on the 16.0 migration is causing a flickering effect that is a bit annoying and does not make complete sense, because if you click more than once the cursor is positioned at the end of the text, which makes it difficult to edit the input.
The counterpart of these changes is that to edit the input using the keyboard we will have to click on the field. Although this is how the module has been operating since its inception.
Before this changes:
After this changes:
cc @Tecnativa TT50439
ping @chienandalu @pedrobaeza