Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] web_m2x_options: Functions used on buttons are not working #2901

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

CarlosRoca13
Copy link
Contributor

Before this PR when trying to create a record using the Dialog, when pressing the buttons Create or Create and Edit they are having no effect.
buttons not working

After this PR the code is addapted to the new dialog to make the buttons work as usual.
buttons working gif

Steps to reproduce the problem:
1. Go to any m2o field
2. Write a name that does not exist
3. Loose the focus
4. Press on button "Create" or "Create and Edit"

cc @Tecnativa TT50338

ping @carolinafernandez-tecnativa @pilarvargas-tecnativa

Before this PR when trying to create a record using the Dialog, when
pressing the buttons Create or Create and Edit they are having no effect.

After this PR the code is addapted to the new dialog to make the buttons
work as usual.

Steps to reproduce the problem:
    1. Go to any m2o field
    2. Write a name that does not exist
    3. Loose the focus
    4. Press on button "Create" or "Create and Edit"
@pilarvargas-tecnativa
Copy link
Contributor

Thanks 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks :)

@CarlosRoca13
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2901-by-CarlosRoca13-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1bb95c2 into OCA:15.0 Jul 31, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 54e3108. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants