Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] web_widget_image_download: migration to 16.0 #2897

Merged

Conversation

manuelregidor
Copy link
Contributor

@manuelregidor manuelregidor commented Jul 29, 2024

Standard migration

The download button has been moved to the top left corner of the image as the web_widget_image_webcam module also includes a button on the bottom of the image. This way we make sure that the buttons row are not wider than the image in case this module is installed along with web_widget_image_webcam.

@HaraldPanten
@ValentinVinagre
@luis-ron

T-6451

kutyel and others added 30 commits July 29, 2024 10:50
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (1 of 1 strings)

Translation: web-12.0/web-12.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/zh_CN/
Currently translated at 100.0% (1 of 1 strings)

Translation: web-12.0/web-12.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-13.0/web-13.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_image_download/
Currently translated at 100.0% (1 of 1 strings)

Translation: web-13.0/web-13.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_image_download/es/
mymage and others added 3 commits July 29, 2024 10:50
Currently translated at 100.0% (1 of 1 strings)

Translation: web-15.0/web-15.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_widget_image_download/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-15.0/web-15.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_widget_image_download/
@manuelregidor manuelregidor force-pushed the 16.0-mig-web_widget_image_download branch 2 times, most recently from 90564bb to 2e7de03 Compare July 29, 2024 09:55
@manuelregidor manuelregidor changed the title [WIP][16.0][MIG] web_widget_image_download: migration to 16.0 [16.0][MIG] web_widget_image_download: migration to 16.0 Jul 29, 2024
@manuelregidor manuelregidor marked this pull request as ready for review July 29, 2024 10:02
@manuelregidor
Copy link
Contributor Author

@luis-ron Could you review, please?

Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM 👍🏻

@manuelregidor
Copy link
Contributor Author

@Tisho99 Could you review, please?

Copy link

@Tisho99 Tisho99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code and functional review

@HaraldPanten
Copy link

@etobella could you assign this migration to us, and merge?

THX!

@etobella
Copy link
Member

/ocabot migration web_widget_image_download

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 31, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 31, 2024
44 tasks
@manuelregidor manuelregidor force-pushed the 16.0-mig-web_widget_image_download branch from 2e7de03 to 9d55e4a Compare August 1, 2024 06:27
@manuelregidor manuelregidor force-pushed the 16.0-mig-web_widget_image_download branch from 9d55e4a to 0ff51e5 Compare August 1, 2024 06:46
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2897-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 58f6473 into OCA:16.0 Aug 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f18b673. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 16.0-mig-web_widget_image_download branch August 1, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.