-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0] mig web chatter position #2895
base: 17.0
Are you sure you want to change the base?
[17.0] mig web chatter position #2895
Conversation
mailing module - Because the chatter in mass mailing form view lie under a notebook tab, if user choose sided chatter, it will disappear
Could you fix precommit errors ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review ok !!
Hello everyone, this PR was created because the other PR (#2893) was not ready. But I think it is now. So if anyone of you has the opportunity to do so, can you go check this one out, for the code review, and merge it when ready? |
This a fork from 2833
I know there is another PR currently opened (2893) but this one doesn't seem to work. On the other hand, the original PR (2833) was working fine. So not knowing why the second one was created, and being in the urge to migrate this module for a customer, I'm opening this PR and letting you decide which one works best for you.