Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] mig web chatter position #2895

Open
wants to merge 16 commits into
base: 17.0
Choose a base branch
from

Conversation

tva-subteno-it
Copy link

This a fork from 2833

I know there is another PR currently opened (2893) but this one doesn't seem to work. On the other hand, the original PR (2833) was working fine. So not knowing why the second one was created, and being in the urge to migrate this module for a customer, I'm opening this PR and letting you decide which one works best for you.

@legalsylvain
Copy link
Contributor

Could you fix precommit errors ?

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link

@antoniocanovas antoniocanovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok !!

@tva-subteno-it
Copy link
Author

Hello everyone, this PR was created because the other PR (#2893) was not ready. But I think it is now. So if anyone of you has the opportunity to do so, can you go check this one out, for the code review, and merge it when ready?
Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.